[REF] Function create_scans_dict from bids_utils is highly inefficient, may be replaceable

[AliceJoubert]

The function create_scans_dict used for AIBL and OASIS converters :

clinica/clinica/iotools/bids_utils.py

Lines 468 to 476 in 6f81685

	def create_scans_dict(
	clinical_data_dir: Path,
	study_name: StudyName,
	clinical_specifications_folder: Path,
	bids_ids: list[str],
	name_column_ids: str,
	name_column_ses: str,
	ses_dict: dict,
	) -> pd.DataFrame:

can be very much improved.

• It uses inefficient arguments. For example, ses_dict is the whole sessions dict used elsewhere to write sessions.tsv but is only used in this function to get sessions numbers :

clinica/clinica/iotools/bids_utils.py

Lines 516 to 519 in 6f81685

	# Init the dictionary with the subject ids
	for bids_id in bids_ids:
	scans_dict[bids_id] = dict()
	for session_id in {"ses-" + key for key in ses_dict[bids_id].keys()}:

• In general, this function lasts 100+ lines when it is supposed to produce a simple scans dict indicating the files found in a category folder (ex : anat). It is probable that it can be replaced by another function already existing.

• OASIS

• AIBL

[github-actions]

This issue is considered stale because it has not received further activity for the last 14 days. You may remove the inactive label or add a comment, otherwise it will be closed after the next 14 days.