Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong env name #579

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: wrong env name #579

merged 1 commit into from
May 3, 2024

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Apr 26, 2024 •
edited
Loading

Description

The management DAO ENS subdomain env var name was not updated after we changed it from
MANAGINGDAO_SUBDOMAIN to MANAGEMENT_DAO_SUBDOMAIN.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.

@heueristik heueristik changed the base branch from develop to main April 26, 2024 14:33
@heueristik heueristik requested a review from Rekard0 April 26, 2024 14:33
@github-actions github-actions bot removed the subgraph label Apr 26, 2024
@heueristik heueristik requested a review from novaknole April 26, 2024 14:33
@heueristik heueristik merged commit e24d9fa into main May 3, 2024
16 checks passed
@heueristik heueristik deleted the feature/fix-env-name branch May 3, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novaknole novaknole novaknole approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @Rekard0 @novaknole