Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amending incorrect build metadata hierarchy #481

Merged
merged 5 commits into from
Oct 6, 2023

Conversation

brickpop
Copy link
Contributor

@brickpop brickpop commented Oct 6, 2023

Description

The prepareUpdate and prepareUninstallation ABI definition should be alongside prepareInstallation and not a child of it.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

This fixes the structure of the Token Voting build metadata. prepareUpdate and prepareUninstallation should not be within the prepareInstallation object.
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhh, good find.

@heueristik heueristik requested a review from Rekard0 October 6, 2023 14:55
@Rekard0 Rekard0 merged commit 91522b3 into develop Oct 6, 2023
11 checks passed
@Rekard0 Rekard0 deleted the fix/token-voting-amend-metadata branch October 6, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants