Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: DAO signature validation #448

Merged
merged 30 commits into from
Sep 21, 2023
Merged

refactor: DAO signature validation #448

merged 30 commits into from
Sep 21, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Aug 23, 2023 •
edited
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: OS-669

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@heueristik heueristik marked this pull request as ready for review August 25, 2023 09:25
mathewmeconry
mathewmeconry suggested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@mathewmeconry mathewmeconry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as suggested in the daily please use a different word than deprecated. I suggest removed or deleted

@heueristik
Copy link
Contributor Author

as suggested in the daily please use a different word than deprecated. I suggest removed or deleted

Changed in aca7c5e

@heueristik heueristik force-pushed the feature/OS-669-dao-refactoring branch from 0189aa0 to ca012cc Compare August 28, 2023 07:53
mathewmeconry
mathewmeconry suggested changes Sep 1, 2023
View reviewed changes
packages/contracts/CHANGELOG.md Outdated Show resolved Hide resolved
packages/contracts/CHANGELOG.md Outdated Show resolved Hide resolved
packages/contracts/test/core/dao/dao.ts Outdated Show resolved Hide resolved
packages/contracts/test/core/dao/dao.ts Show resolved Hide resolved
packages/contracts/test/plugins/governance/multisig/multisig.ts Show resolved Hide resolved
packages/contracts/test/upgrade/dao.ts Outdated Show resolved Hide resolved
Rekard0
Rekard0 reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DaoFactory Changed:
Missing deploy script, i would either:

  • implement update deploy script for v1.4
  • create a task with clear description

@heueristik heueristik merged commit 904efba into develop Sep 21, 2023
11 checks passed
@heueristik heueristik deleted the feature/OS-669-dao-refactoring branch September 21, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@mathewmeconry mathewmeconry mathewmeconry approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @mathewmeconry @Rekard0