From c559bfe36b2184e268d5b8469627bc092555363f Mon Sep 17 00:00:00 2001 From: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com> Date: Tue, 6 Feb 2024 12:14:45 +0100 Subject: [PATCH] fix: wrong import, missing await, incorrect comment (#526) * fix: wrong import path * docs: wrong NatSpec * fix: missing await --- packages/contracts/hardhat.config.ts | 2 +- .../src/framework/plugin/setup/PluginSetupProcessor.sol | 2 +- .../test/framework/utils/ens/ens-subdomain-registry.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/contracts/hardhat.config.ts b/packages/contracts/hardhat.config.ts index 3036e57fc..3688f2f95 100644 --- a/packages/contracts/hardhat.config.ts +++ b/packages/contracts/hardhat.config.ts @@ -1,5 +1,5 @@ import networks, {ContractsNetworkConfig} from './networks'; -import {AragonPluginRepos, TestingFork} from './utils/types'; +import {AragonPluginRepos, TestingFork} from './types/hardhat'; import {NetworkConfigs} from '@aragon/osx-commons-configs'; import '@nomicfoundation/hardhat-chai-matchers'; import '@nomicfoundation/hardhat-network-helpers'; diff --git a/packages/contracts/src/framework/plugin/setup/PluginSetupProcessor.sol b/packages/contracts/src/framework/plugin/setup/PluginSetupProcessor.sol index 50e04f9a7..88ddd92e0 100644 --- a/packages/contracts/src/framework/plugin/setup/PluginSetupProcessor.sol +++ b/packages/contracts/src/framework/plugin/setup/PluginSetupProcessor.sol @@ -498,7 +498,7 @@ contract PluginSetupProcessor is ProtocolVersion { /// @notice Applies the permissions of a prepared update of an UUPS upgradeable proxy contract to a DAO. /// @param _dao The address of the updating DAO. - /// @param _params The struct containing the parameters for the `applyInstallation` function. + /// @param _params The struct containing the parameters for the `applyUpdate` function. function applyUpdate( address _dao, ApplyUpdateParams calldata _params diff --git a/packages/contracts/test/framework/utils/ens/ens-subdomain-registry.ts b/packages/contracts/test/framework/utils/ens/ens-subdomain-registry.ts index 490c32ebc..7c4fb060b 100644 --- a/packages/contracts/test/framework/utils/ens/ens-subdomain-registry.ts +++ b/packages/contracts/test/framework/utils/ens/ens-subdomain-registry.ts @@ -231,7 +231,7 @@ describe('ENSSubdomainRegistrar', function () { it('reverts if the approval of the registrar is removed', async () => { // Initialize the registrar with the 'test' domain - registrar.initialize( + await registrar.initialize( managingDao.address, ens.address, ensDomainHash('test')