diff --git a/packages/contracts/test/core/dao/dao.ts b/packages/contracts/test/core/dao/dao.ts index 8fcc3e389..82320c083 100644 --- a/packages/contracts/test/core/dao/dao.ts +++ b/packages/contracts/test/core/dao/dao.ts @@ -141,11 +141,6 @@ describe('DAO', function () { ownerAddress, PERMISSION_IDS.UPGRADE_DAO_PERMISSION_ID ), - dao.grant( - dao.address, - ownerAddress, - PERMISSION_IDS.VALIDATE_SIGNATURE_PERMISSION_ID - ), dao.grant( dao.address, ownerAddress, @@ -1230,7 +1225,7 @@ describe('DAO', function () { ).to.be.eq(true); }); - it('reverts all signatures requests by default', async () => { + it('treats signatures as invalid by default if no permission is set', async () => { const caller = signers[0]; const signer = signers[1]; @@ -1238,9 +1233,10 @@ describe('DAO', function () { const hash = ethers.utils.hashMessage(message); const signature = await signer.signMessage(message); - // The caller can validate signatures now. - expect(await dao.connect(caller).isValidSignature(hash, signature)).to.be - .reverted; + // Because no permission is set, the signature is said to be invalid + expect( + await dao.connect(caller).isValidSignature(hash, signature) + ).to.equal(INVALID_ERC1271_SIGNATURE); }); it('allows caller specific signature validation', async () => {