-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Datasource Environment Selector Not Appearing in Deployed Version of App #31266
Comments
@dzelemba Thank you for raising this. Seems like a bug that was introduced with the recent changes. We will try to prioritize and resolve it as soon as possible. |
Thanks all for taking a look here! Do you have any approximate ETA on the fix? We're just trying to decide how much work to invest in a workaround here. |
Hey @dzelemba |
Hey folks -- just checking in here :) I see there is a PR out which is exciting to see. But doesn't look like much activity last week. |
Hey @dzelemba, apologies for the delay. We were just revisiting the logic for the env switcher in view mode. Will push it to release this week. |
## Description Adds multiple env switcher to the bottom bar Fixes #31266 ## Automation /ok-to-test tags="@tag.MultiEnv" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8440725278> > Commit: `eae7d87a07c270a460049f124fe90277f997cd58` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8440725278&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a `BottomBar` component in the `AppViewer` for enhanced navigation and quick actions, conditionally displayed based on multiple environments and specific feature flags. - Added a custom React hook `useShowEnvSwitcher` to determine the visibility of the environment switcher based on various conditions. - **Refactor** - Improved visibility of the `SwitchEnvironment` component and `QuickGitActions` by adjusting their rendering logic, ensuring they are always visible when `viewMode` is false. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Multi env disappearing from bottom bar in editor mode Fixes #31266 #32270 ## Automation /ok-to-test tags="@tag.MultiEnv" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8506755504> > Commit: `2a72270e1d2eee93391bdb098f3bb708c0bb5a8e` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8506755504&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced environment switching functionality to support multiple environments based on various conditions including view and preview modes. - **Refactor** - Simplified the bottom bar display logic across the app using the updated `useShowEnvSwitcher` hook. - Revised environment and feature flag handling in the App Viewer and Editor IDE components for improved clarity and efficiency. - Updated `EditorWrapperContainer` to adjust its height dynamically based on the presence of the bottom bar. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
@dzelemba Update on the fix you've been eagerly awaiting. In our latest round of internal testing, we discovered that the fix didn't meet our quality standards due to unforeseen complications arising from our code's complexity. We wanted to reach out proactively to let you know before this became a further concern for you. We're dedicated to getting this right, which means it'll take a couple more releases to fully address the issue, but our focus is on quality and efficacy. We know this fix is important to you, so if there's anything specific we can do to help in the meantime, please let us know. Your patience and feedback are invaluable to us as we work to make things right. |
Hi @riteshkew any updates here? |
@dzelemba We're still in development and actively working so that it reaches you as soon as possible. Please expect to hear back from us within the next two weeks with some good news. Truly appreciate the patience you have shown all this while here with us. |
Hi @riteshkew checkingin again :) |
Hello @dzelemba, We apolgise for the delay in getting back to you. We genuinely appreciate your patience throughout this process. I understand how frustrating waiting can be, especially when you're looking forward to a resolution. We have been carefully considering the best approach to handle your request, and unfortunately, we won’t be able to proceed as initially hoped. However, we are committed to finding the best alternative solution for you. To ensure we fully address your concerns and discuss the next steps, could we have a call at your convenience? We aim to resolve this matter to your satisfaction, and speaking directly might be the most effective way to do that. Please use this link for scheduling Thank you for being so understanding, and I look forward to our conversation. |
We have the same issue, We always want to develop features, publish content, test the published content on staging before it's done on prod. at least you could allow having it by an env variable/feature flag, but not removing it completely, couldn't you? @riteshkew @brayn003 |
I just wanted to highlight that switching env is almost a standard feature for similar tools. |
We truly appreciate your feedback and deeply apologize for any inconvenience this situation may have caused. Back in February 2024, we observed limited usage of this feature and decided to retire it to reduce the maintenance overhead. Our assumption was that users could still rely on edit or preview mode in a single instance or utilize a multiple-instance strategy as a workaround. Unfortunately, we realize now that we misjudged the impact of this decision. After carefully reviewing multiple user requests, we understand that this feature was valuable to the users who were leveraging it, and we should have considered an alternative solution for the specific use case you both mentioned before phasing it out. We did explore options like providing an admin setting to control its visibility, as mentioned by @mohamedgomran, but eventually ended up against it. We sincerely apologize for this oversight and any difficulties it may have caused. Please be rest assured that we are actively working to resolve this issue as quickly as possible. While a complete UI-based solution requires careful consideration and will take some time, we are committed to ensuring the URL-based switching is seamless in the interim, so that you remain unblocked and can use this feature as closely as possible to your needs. Thank you for your continued patience and support. |
@riteshkew Thank you for your message and for taking our feedback into account. We look forward to seeing this feature reintegrated in the next releases. |
@riteshkew can you please provide an understanding of the progress for the url based solution? |
@sonali-humanedge We appreciate your patience and understanding as we work towards the solution. The team is actively working on refinfing the architecture for the URL-based switching solution that addresses your needs without introducing additional technical debt. Our goal is to provide a seamless experience, and we expect this improvement to be available in production by the end of this month. Your feedback has been invaluable in guiding this process, and we remain committed to resolving user problems effectively and comprehensively. Thank you again for your support as we work to enhance your experience. |
Is there an existing issue for this?
Description
According to the docs -- https://docs.appsmith.com/connect-data/how-to-guides/setup-datasource-environments#switch-environments :
In addition, users with the necessary permissions can also switch to the Staging environment configuration when accessing the app in View mode. For more information on permissions, you can refer to the [Granular Access Control](https://docs.appsmith.com/advanced-concepts/granular-access-control).
However, I don't see any selector in the View mode for switching environments. I'm assuming that since I can Edit the app I should have the permissions to switch datasources.
Steps To Reproduce
Public Sample App
No response
Environment
Production
Issue video log
https://www.loom.com/share/89371ffff6de43859e4e0829a99f808d
Version
Self Hosted -- Appsmith v1.10
The text was updated successfully, but these errors were encountered: