Skip to content

Compilation failures on 5.10 with new typed throws #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0xTim opened this issue Mar 18, 2025 · 1 comment · Fixed by #168
Closed

Compilation failures on 5.10 with new typed throws #166

0xTim opened this issue Mar 18, 2025 · 1 comment · Fixed by #168

Comments

@0xTim
Copy link

0xTim commented Mar 18, 2025

The new typed throws are breaking builds on 5.10, even though they're supposed to be wrapped in a compiler check.

This is possibly related to swift-server/async-http-client#810.

See https://github.com/vapor/vapor/actions/runs/13922803636/job/38961918498?pr=3314 for an example build failure
@0xTim 0xTim changed the title Compilations failures on 5.10 with new typed throws Compilation failures on 5.10 with new typed throws Mar 18, 2025
@dimitribouniol dimitribouniol marked this as a duplicate of #167 Mar 18, 2025
@dimitribouniol dimitribouniol mentioned this issue Mar 18, 2025
Closed
@0xTim
Copy link
Author

0xTim commented Mar 18, 2025

This is the issue tracking this on Swift swiftlang/swift#79285

@FranzBusch FranzBusch mentioned this issue Mar 18, 2025
Merged
czechboy0 pushed a commit that referenced this issue Mar 18, 2025
@FranzBusch
Fix 5.10 compile on Ubuntu 24.04 (#168)
44491db 
Specifically Swift 5.10 on Intel on Ubuntu Noble (24.04) has a crazy bug
which leads to compilation failures in a #if compiler(>=6.0) block:
swiftlang/swift#79285 .

This workaround fixes the compilation by changing the whitespace.

Fixes #166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 5.10 compile on Ubuntu 24.04 apple/swift-metrics
1 participant
@0xTim