Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sendable conformance to appropriate types #150

Open
jmjauer opened this issue Mar 9, 2023 · 7 comments
Open

Add sendable conformance to appropriate types #150

jmjauer opened this issue Mar 9, 2023 · 7 comments

Comments

@jmjauer
Copy link

jmjauer commented Mar 9, 2023

Add Sendable conformance to appropriate types would allow to enabled additional safety checks at compile time. Without it, developers have to guess whether a type is Sendable or not.

@Sajjon
Copy link
Contributor

Sajjon commented Mar 26, 2023

Ah the by Github listed "mention" was a red herring, I was trying to write "amount: 150" using pound sign, which was a silly thing to do, since I forgot GH lists is a references... Sorry for misleading "mention".

But YES I agree Sendable would be great to have, when safe to mark as such!

@Sajjon
Copy link
Contributor

Sajjon commented Apr 13, 2023

I see no reason for ECDSASignature to not be Sendable, nor any reason for why all PublicKeys cannot be Sendable.

@Lukasa
Copy link
Collaborator

Lukasa commented Apr 13, 2023

Huh, I thought I commented on this. Regardless: we've heard this feedback internally, thanks for providing it!

@Sajjon
Copy link
Contributor

Sajjon commented Apr 13, 2023

@Lukasa mind if I submit a PR making PublicKeys Equatable? I know different topic... but IMO falls under non dangerous protocol conformances helping devs :)

@Lukasa
Copy link
Collaborator

Lukasa commented Apr 14, 2023

This is a good suggestion, thanks. As this affects the common API layer between CryptoKit and Swift Crypto, while you can make a PR we will be unable to merge it until an equivalent change ships in CryptoKit.

@jmjauer
Copy link
Author

jmjauer commented Apr 14, 2023

Are the people who maintain CryptoKit the same ones who maintain Swift Crypto - or should I post this suggestion somewhere else?

@Lukasa
Copy link
Collaborator

Lukasa commented Apr 14, 2023

I'm afraid that's not something I can get into detail about, but I will say that filing a request using Feedback Assistant is always valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants