Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake build does follow patterns from other swift-* projects (e.g. collections) #59

Open
ktoso opened this issue Oct 5, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@ktoso
Copy link
Member

ktoso commented Oct 5, 2022

When recently consuming swift-atomics and swift-collections I noticed a weird difference in where cmake files end up:

-> % find .build/checkouts/swift-atomics | grep onfig.cmake
.build/checkouts/swift-atomics/swift-atomics-config.cmake


-> % find .build/checkouts/swift-collections | grep onfig.cmake
.build/checkouts/swift-collections/cmake/modules/SwiftCollectionsConfig.cmake
.build/checkouts/swift-collections/cmake/modules/SwiftCollectionsConfig.cmake.in

probably the files in atomics should also end up in cmake/modules rather than in top level.
This made consuming swift-atomics a bit confusing; though everything works, it might be nicer to follow the same patterns in our packages.

@ktoso ktoso added the bug Something isn't working label Oct 5, 2022
@lorentey lorentey added this to the 1.1.0 milestone Dec 9, 2022
@lorentey
Copy link
Member

lorentey commented Mar 17, 2023

@ktoso would fixing this break these dependents now?

@lorentey lorentey removed this from the 1.1.0 milestone Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants