Skip to content

CMake build does follow patterns from other swift-* projects (e.g. collections) #59

Open

Description

@ktoso

When recently consuming swift-atomics and swift-collections I noticed a weird difference in where cmake files end up:

-> % find .build/checkouts/swift-atomics | grep onfig.cmake
.build/checkouts/swift-atomics/swift-atomics-config.cmake


-> % find .build/checkouts/swift-collections | grep onfig.cmake
.build/checkouts/swift-collections/cmake/modules/SwiftCollectionsConfig.cmake
.build/checkouts/swift-collections/cmake/modules/SwiftCollectionsConfig.cmake.in

probably the files in atomics should also end up in cmake/modules rather than in top level.
This made consuming swift-atomics a bit confusing; though everything works, it might be nicer to follow the same patterns in our packages.

Activity

  1. added
    bugSomething isn't working
    on Oct 5, 2022
  2. added this to the 1.1.0 milestone on Dec 9, 2022
  3. lorentey commented on Mar 17, 2023

    @lorentey
    Member

    @ktoso would fixing this break these dependents now?

  4. removed this from the 1.1.0 milestone on Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions