In bash completion scripts, replace max int64 magic number with -1 to accept all subsequent non-flag/non-option/non-option-value tokens as positionals.

Signed-off-by: Ross Goldberg <[email protected]>

Author: rgoldberg

Sources/ArgumentParser/Completions/BashCompletionsGenerator.swift

@@ -126,7 +126,7 @@ extension CommandInfoV0 {
             fi
 
             # ${word} is neither a flag, nor an option, nor an option value
-            if [[ "${positional_number}" -lt "${positional_count}" ]]; then
+            if [[ "${positional_number}" -lt "${positional_count}" || "${positional_count}" -lt 0 ]]; then
                 # ${word} is a positional
                 ((positional_number++))
                 unset "unparsed_words[${word_index}]"
@@ -226,7 +226,7 @@ extension CommandInfoV0 {
             \(declareTopLevelArray)repeating_options=(\(options.filter(\.isRepeating).flatMap(\.completionWords).joined(separator: " ")))
             \(declareTopLevelArray)non_repeating_options=(\(options.filter { !$0.isRepeating }.flatMap(\.completionWords).joined(separator: " ")))
             \(offerFlagsOptionsFunctionName) \
-        \(positionalArguments.contains { $0.isRepeating } ? 9_223_372_036_854_775_807 : positionalArguments.count)
+        \(positionalArguments.contains { $0.isRepeating } ? -1 : positionalArguments.count)
 
         """
     }

Tests/ArgumentParserExampleTests/Snapshots/testMathBashCompletionScript().bash

@@ -100,7 +100,7 @@ __math_offer_flags_options() {
         fi
 
         # ${word} is neither a flag, nor an option, nor an option value
-        if [[ "${positional_number}" -lt "${positional_count}" ]]; then
+        if [[ "${positional_number}" -lt "${positional_count}" || "${positional_count}" -lt 0 ]]; then
             # ${word} is a positional
             ((positional_number++))
             unset "unparsed_words[${word_index}]"
@@ -187,15 +187,15 @@ _math_add() {
     non_repeating_flags=(--hex-output -x --version -h --help)
     repeating_options=()
     non_repeating_options=()
-    __math_offer_flags_options 9223372036854775807
+    __math_offer_flags_options -1
 }
 
 _math_multiply() {
     repeating_flags=()
     non_repeating_flags=(--hex-output -x --version -h --help)
     repeating_options=()
     non_repeating_options=()
-    __math_offer_flags_options 9223372036854775807
+    __math_offer_flags_options -1
 }
 
 _math_stats() {
@@ -226,7 +226,7 @@ _math_stats_average() {
     non_repeating_flags=(--version -h --help)
     repeating_options=()
     non_repeating_options=(--kind)
-    __math_offer_flags_options 9223372036854775807
+    __math_offer_flags_options -1
 
     # Offer option value completions
     case "${prev}" in
@@ -242,15 +242,15 @@ _math_stats_stdev() {
     non_repeating_flags=(--version -h --help)
     repeating_options=()
     non_repeating_options=()
-    __math_offer_flags_options 9223372036854775807
+    __math_offer_flags_options -1
 }
 
 _math_stats_quantiles() {
     repeating_flags=()
     non_repeating_flags=(--version -h --help)
     repeating_options=()
     non_repeating_options=(--file --directory --shell --custom --custom-deprecated)
-    __math_offer_flags_options 9223372036854775807
+    __math_offer_flags_options -1
 
     # Offer option value completions
     case "${prev}" in
@@ -298,7 +298,7 @@ _math_help() {
     non_repeating_flags=(--version)
     repeating_options=()
     non_repeating_options=()
-    __math_offer_flags_options 9223372036854775807
+    __math_offer_flags_options -1
 }
 
 complete -o filenames -F _math math

Tests/ArgumentParserUnitTests/Snapshots/testBase_Bash().bash

@@ -100,7 +100,7 @@ __base-test_offer_flags_options() {
         fi
 
         # ${word} is neither a flag, nor an option, nor an option value
-        if [[ "${positional_number}" -lt "${positional_count}" ]]; then
+        if [[ "${positional_number}" -lt "${positional_count}" || "${positional_count}" -lt 0 ]]; then
             # ${word} is a positional
             ((positional_number++))
             unset "unparsed_words[${word_index}]"