Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider shadowing jackson-databind dependency #151

Open
InnokentiyStruchkov opened this issue Mar 4, 2025 · 1 comment
Open

Consider shadowing jackson-databind dependency #151

InnokentiyStruchkov opened this issue Mar 4, 2025 · 1 comment

Comments

@InnokentiyStruchkov
Copy link

FasterXML's Jackson is widely used across the industry, especially in popular and essential libraries, such as Redisson, AWS SDK, etc.

But a lot of such libraries don't shadow the dependency on Jackson. This can introduce serious incompatibilities with existing internal codebases and even with other 3rd-party libraries that also depend on Jackson.

Please, consider shadowing the dependency on Jackson in app-store-server-library-java in future releases.

@alexanderjordanbaker
Copy link
Collaborator

@InnokentiyStruchkov Thank you for the feedback. If we were to shade Jackson, then all the types that we expose that are Jackson compatible would stop being Jackson compatible for any user of the library. As the library supports a wide range of Jackson versions, and any consumer can override the Jackson version as they will, I don’t think shading Jackson would effect compatibility significantly but would be a breaking change for consumers of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants