From 2dc1bdb4fab928ce677592af725d4a327a567047 Mon Sep 17 00:00:00 2001
From: Luis Guzman <luisguzman@appdevforall.org>
Date: Fri, 25 Sep 2026 14:19:29 -0600
Subject: [PATCH] K2GO-426 fix(modules): show the detail hero glyph centered on
 a neutral panel

The module detail hero drew the raw glyph full width with no tint. It was hard
to read on the dark theme and it looked cramped. The glyph now sits centered on
a neutral rounded panel (k2go_hero_panel, filled k2go_hairline) and is tinted
from the theme (k2go_teal), the same look the Dashboard detail already used.

The Dashboard uses one drawable (ic_card_dashnode) for both the list row bullet
and the detail hero, so the two match. Presentational only: no change to install
or selection logic.
---
 .../k2go/redesign/DashboardDetailFragment.java         |  4 +++-
 .../app/src/main/res/drawable/ic_card_dashnode.xml     |  3 +++
 .../app/src/main/res/drawable/k2go_hero_panel.xml      |  7 +++++++
 .../main/res/layout/fragment_k2go_module_detail.xml    | 10 +++++++---
 4 files changed, 20 insertions(+), 4 deletions(-)
 create mode 100644 controller/app/src/main/res/drawable/k2go_hero_panel.xml

diff --git a/controller/app/src/main/java/org/appdevforall/k2go/redesign/DashboardDetailFragment.java b/controller/app/src/main/java/org/appdevforall/k2go/redesign/DashboardDetailFragment.java
index e6ef2f705..0e5cdbdd4 100644
--- a/controller/app/src/main/java/org/appdevforall/k2go/redesign/DashboardDetailFragment.java
+++ b/controller/app/src/main/java/org/appdevforall/k2go/redesign/DashboardDetailFragment.java
@@ -97,7 +97,9 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
         back.setText("‹ " + getString(R.string.k2go_mod_back));
         back.setOnClickListener(v -> requireActivity().getOnBackPressedDispatcher().onBackPressed());
 
-        ((ImageView) root.findViewById(R.id.k2go_moddet_image)).setImageResource(R.drawable.k2go_module_placeholder);
+        // K2GO-426: use the same glyph the list row bullet uses (ic_card_dashnode), on the shared hero
+        // panel, so the Dashboard is consistent between the list and the detail.
+        ((ImageView) root.findViewById(R.id.k2go_moddet_image)).setImageResource(R.drawable.ic_card_dashnode);
         ((TextView) root.findViewById(R.id.k2go_moddet_title)).setText(R.string.k2go_dash_detail_title);
         ((TextView) root.findViewById(R.id.k2go_moddet_sub)).setText(R.string.k2go_dash_detail_sub);
         ((TextView) root.findViewById(R.id.k2go_moddet_desc)).setText(R.string.k2go_dash_detail_desc);
diff --git a/controller/app/src/main/res/drawable/ic_card_dashnode.xml b/controller/app/src/main/res/drawable/ic_card_dashnode.xml
index 8398015e0..bfacc66d4 100644
--- a/controller/app/src/main/res/drawable/ic_card_dashnode.xml
+++ b/controller/app/src/main/res/drawable/ic_card_dashnode.xml
@@ -1,3 +1,6 @@
+<!-- K2GO-426: Dashboard glyph (Material dashboard, four rectangles forming a square). One drawable for
+     both the Module management list row bullet and the detail hero, so the Dashboard stays consistent.
+     Tinted from the theme at runtime; the fill here is a placeholder color. -->
 <vector xmlns:android="http://schemas.android.com/apk/res/android" android:width="40dp" android:height="40dp" android:viewportWidth="24" android:viewportHeight="24">
     <path android:fillColor="#000000" android:pathData="M3 13h8V3H3v10zm0 8h8v-6H3v6zm10 0h8V11h-8v10zm0-18v6h8V3h-8z" />
 </vector>
diff --git a/controller/app/src/main/res/drawable/k2go_hero_panel.xml b/controller/app/src/main/res/drawable/k2go_hero_panel.xml
new file mode 100644
index 000000000..3c03d9ed1
--- /dev/null
+++ b/controller/app/src/main/res/drawable/k2go_hero_panel.xml
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- K2GO-426: neutral rounded panel behind the module detail hero glyph. Theme-aware fill so the
+     centered glyph reads on both themes (was: raw full-width glyph, black on dark). -->
+<shape xmlns:android="http://schemas.android.com/apk/res/android" android:shape="rectangle">
+    <solid android:color="@color/k2go_hairline" />
+    <corners android:radius="18dp" />
+</shape>
diff --git a/controller/app/src/main/res/layout/fragment_k2go_module_detail.xml b/controller/app/src/main/res/layout/fragment_k2go_module_detail.xml
index 8d591852c..215f583be 100644
--- a/controller/app/src/main/res/layout/fragment_k2go_module_detail.xml
+++ b/controller/app/src/main/res/layout/fragment_k2go_module_detail.xml
@@ -32,14 +32,18 @@
                 android:textAppearance="?attr/textAppearanceBodyMedium"
                 android:textColor="@color/k2go_teal" />
 
+            <!-- K2GO-426: hero = neutral panel background + centered glyph. The glyph (src) is set in
+                 code per module and tinted from the theme; padding shrinks it and gives an even margin,
+                 so every module reads the same on both themes (was: raw full-width glyph, black on dark). -->
             <ImageView
                 android:id="@+id/k2go_moddet_image"
                 android:layout_width="match_parent"
-                android:layout_height="wrap_content"
+                android:layout_height="180dp"
                 android:layout_marginTop="8dp"
-                android:adjustViewBounds="true"
+                android:background="@drawable/k2go_hero_panel"
+                android:padding="32dp"
                 android:scaleType="fitCenter"
-                android:src="@drawable/k2go_module_placeholder"
+                android:tint="@color/k2go_teal"
                 android:importantForAccessibility="no" />
 
             <TextView