K2GO-434 refactor(setup): import the verdict types and add two verdict tests

Review nits on the slice-1 extraction: replace the fully-qualified
setup.domain references in render() with imports, and cover the
noRest-without-proot branch and a slow server restart in a REST run.

Author: luisguzman-adfa

controller/app/src/main/java/org/appdevforall/k2go/redesign/SetupProgressActivity.java

@@ -43,6 +43,9 @@
 import org.appdevforall.k2go.kolibri.presentation.KolibriSeedService;
 import org.appdevforall.k2go.kolibri.presentation.KolibriSeedState;
 import org.appdevforall.k2go.kolibri.presentation.KolibriSeedingFragment;
+import org.appdevforall.k2go.setup.domain.RunSnapshot;
+import org.appdevforall.k2go.setup.domain.RunVerdict;
+import org.appdevforall.k2go.setup.domain.StreamState;
 import org.appdevforall.k2go.system.data.PendingContent;
 import org.appdevforall.k2go.system.domain.OperationDispatcher;
 import org.appdevforall.k2go.system.domain.ContentType;
@@ -795,19 +798,16 @@ private void render() {
         int booksFailed = failedCount(booksSession ? BooksDownloadService.status() : null, BooksDownloadService.FAILED);
         boolean forgejoSeedFailed = forgejoSeedInSession()
                 && org.appdevforall.k2go.forgejo.presentation.ForgejoSeedRepository.get().isFailed();
-        org.appdevforall.k2go.setup.domain.RunVerdict verdict =
-                org.appdevforall.k2go.setup.domain.RunVerdict.of(new org.appdevforall.k2go.setup.domain.RunSnapshot.Builder()
-                        .noRest(noRest).prootShown(prootShown).moduleShown(moduleShown).drained(drained)
-                        .queueTerminalNotRunning(queueTerminalNotRunning).moduleServerSettled(moduleServerSettled)
-                        .batchServerSlow(batchServerSlow).seedPendingRun(seedPendingRun)
-                        .zim(new org.appdevforall.k2go.setup.domain.StreamState(
-                                zimSession, zimSession && ZimDownloadService.isComplete(), zimFailed))
-                        .books(new org.appdevforall.k2go.setup.domain.StreamState(
-                                booksSession, booksSession && BooksDownloadService.isComplete(), booksFailed))
-                        .kolibri(new org.appdevforall.k2go.setup.domain.StreamState(
-                                kolibriState.hasSession(), kolibriState.hasSession() && kolibriState.isComplete(), kolibriState.failedCount()))
-                        .prootFailed(prootFailed).forgejoSeedFailed(forgejoSeedFailed)
-                        .build());
+        RunVerdict verdict = RunVerdict.of(new RunSnapshot.Builder()
+                .noRest(noRest).prootShown(prootShown).moduleShown(moduleShown).drained(drained)
+                .queueTerminalNotRunning(queueTerminalNotRunning).moduleServerSettled(moduleServerSettled)
+                .batchServerSlow(batchServerSlow).seedPendingRun(seedPendingRun)
+                .zim(new StreamState(zimSession, zimSession && ZimDownloadService.isComplete(), zimFailed))
+                .books(new StreamState(booksSession, booksSession && BooksDownloadService.isComplete(), booksFailed))
+                .kolibri(new StreamState(kolibriState.hasSession(),
+                        kolibriState.hasSession() && kolibriState.isComplete(), kolibriState.failedCount()))
+                .prootFailed(prootFailed).forgejoSeedFailed(forgejoSeedFailed)
+                .build());
         boolean allComplete = verdict.allComplete();
 
         // Status dot + line. While waiting, a long-stuck engine shows a softer "taking longer"

controller/app/src/test/java/org/appdevforall/k2go/setup/domain/RunVerdictTest.java

@@ -119,6 +119,22 @@ public void failedTotalSumsEverySource() {
         assertTrue(v.failure());
     }
 
+    @Test
+    public void noRestWithoutProotUsesRestRule() {
+        // noRest is true but no proot stage is present: the branch selector must fall to the REST rule.
+        RunVerdict v = RunVerdict.of(restDone().noRest(true).prootShown(false).build());
+        assertTrue(v.success());
+    }
+
+    @Test
+    public void slowServerRestartInRestRunIsFailure() {
+        RunVerdict v = RunVerdict.of(restDone()
+                .moduleShown(true).moduleServerSettled(true).batchServerSlow(true).build());
+        assertTrue(v.allComplete());
+        assertFalse(v.success());
+        assertTrue(v.failure());
+    }
+
     @Test
     public void streamSettledForCompletion() {
         assertTrue(new StreamState(false, false, 0).settledForCompletion());   // no session