ADFA-4901: open the maps progress detail from the finishing-setup card

The maps stage row in the Finishing-setup index was not tappable (its
richer detail was deferred). Make it open its own progress detail like the
ZIM/Books rows, once the stage has started. Maps is a single proot runrole,
so the detail is the queue-driven Preparing card (spinner + phase), reused
in a new observe-only (fromIndex) mode that never (re)starts the install.

Author: luisguzman-adfa

controller/app/src/main/java/org/iiab/controller/redesign/MapsPreparingFragment.java

@@ -30,6 +30,7 @@
 public class MapsPreparingFragment extends Fragment {
 
     private static final String ARG_LEVELS = "levels";
+    private static final String ARG_FROM_INDEX = "fromIndex";
 
     public static MapsPreparingFragment newInstance(String[] levels) {
         MapsPreparingFragment f = new MapsPreparingFragment();
@@ -39,29 +40,48 @@ public static MapsPreparingFragment newInstance(String[] levels) {
         return f;
     }
 
+    /** ADFA-4901: open as the maps detail inside the Finishing-setup index — observe only, never
+     *  (re)start the install, and hide this fragment's own "Run in background" button (the index
+     *  host provides Back/Finish). Mirrors ZimPreparingFragment.newInstance(fromIndex). */
+    public static MapsPreparingFragment newInstance(boolean fromIndex) {
+        MapsPreparingFragment f = new MapsPreparingFragment();
+        Bundle b = new Bundle();
+        b.putBoolean(ARG_FROM_INDEX, fromIndex);
+        f.setArguments(b);
+        return f;
+    }
+
     private TextView status;
+    private boolean fromIndex = false;  // ADFA-4901: hosted by the Finishing-setup index (observe only)
     private boolean launched = false;   // ADFA-4900: guard against re-launching maps on view recreation
 
     @Nullable
     @Override
     public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle s) {
         View root = inflater.inflate(R.layout.fragment_k2go_maps_preparing, container, false);
 
+        fromIndex = getArguments() != null && getArguments().getBoolean(ARG_FROM_INDEX, false);
+
         status = root.findViewById(R.id.k2go_prep_status);
         status.setText(getString(R.string.k2go_maps_phase_prepared));
 
-        // Run in background -> back to the Get More hub (drops the whole Maps flow off the
-        // back stack), the build keeps going in the foreground service.
-        root.findViewById(R.id.k2go_prep_run_bg).setOnClickListener(v -> {
-            if (getActivity() instanceof SetupLibraryActivity) {
-                ((SetupLibraryActivity) getActivity()).backToGetMoreHub();
-            }
-        });
+        View runBg = root.findViewById(R.id.k2go_prep_run_bg);
+        if (fromIndex) {
+            runBg.setVisibility(View.GONE);   // the index host provides Back/Finish; this card only observes
+        } else {
+            // Run in background -> back to the Get More hub (drops the whole Maps flow off the
+            // back stack), the build keeps going in the foreground service.
+            runBg.setOnClickListener(v -> {
+                if (getActivity() instanceof SetupLibraryActivity) {
+                    ((SetupLibraryActivity) getActivity()).backToGetMoreHub();
+                }
+            });
+        }
 
-        // Start the real install only on first entry (not on a config-change recreation, and not
-        // if a maps job is already running/done from this session).
+        // Start the real install only on first entry (not on a config-change recreation, not when
+        // hosted as the Finishing-setup detail, and not if a maps job is already running/done).
         String[] levels = getArguments() != null ? getArguments().getStringArray(ARG_LEVELS) : null;
-        if (s == null && !launched
+        if (s == null && !launched && !fromIndex
                 && getActivity() instanceof SetupLibraryActivity
                 && !ModuleQueueRepository.get().isRunning()
                 && ModuleQueueRepository.get().current().phase != ModuleQueueState.Phase.DONE) {

controller/app/src/main/java/org/iiab/controller/redesign/SetupProgressActivity.java

@@ -371,6 +371,16 @@ private View mapsRow() {
         sub.setTextColor(ContextCompat.getColor(this, failed ? R.color.k2go_amber_text : R.color.k2go_muted));
         col.addView(sub);
         row.addView(col, new LinearLayout.LayoutParams(0, LinearLayout.LayoutParams.WRAP_CONTENT, 1f));
+
+        // ADFA-4901: like the ZIM/Books rows, maps opens its own progress detail once the stage has
+        // started (running or done). Maps is a single proot runrole, so the detail is the queue-driven
+        // Preparing card (spinner + phase), not a per-item checklist.
+        ImageView chev = new ImageView(this);
+        chev.setImageResource(R.drawable.ic_chevron_right);
+        chev.setColorFilter(ContextCompat.getColor(this, R.color.k2go_muted));
+        chev.setVisibility(started ? View.VISIBLE : View.INVISIBLE);
+        row.addView(chev, new LinearLayout.LayoutParams(px(24), px(24)));
+        if (started) row.setOnClickListener(v -> openDetail("maps"));
         return row;
     }
 
@@ -421,8 +431,10 @@ private void goHome(boolean clearSessions) {
     // ---- detail: host the real per-module card ----
     private void openDetail(String key) {
         showingDetail = true;
-        androidx.fragment.app.Fragment f = "zim".equals(key)
-                ? ZimPreparingFragment.newInstance(true) : BooksDownloadsFragment.newInstance(true);
+        androidx.fragment.app.Fragment f;
+        if ("zim".equals(key)) f = ZimPreparingFragment.newInstance(true);
+        else if ("maps".equals(key)) f = MapsPreparingFragment.newInstance(true);   // ADFA-4901: observe-only
+        else f = BooksDownloadsFragment.newInstance(true);
         getSupportFragmentManager().beginTransaction().replace(R.id.k2go_sp_fraghost, f).commit();
         indexScroll.setVisibility(View.GONE);
         detailRoot.setVisibility(View.VISIBLE);