Skip to content

Commit 510667d

Browse files
K2GO-439 fix(theme): drop windowLightNavigationBar (NewApi vs minSdk 24)
Lint NewApi blocks android:windowLightNavigationBar in values/ (it needs API 27, minSdk is 24). The reported issue is the status bar, and the navigation bar renders correctly, so drop the attr instead of gating it in values-v27. windowLightStatusBar (API 23) stays and still fixes the light-theme icons.
1 parent 3138c5c commit 510667d

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

‎controller/app/src/main/res/values/themes_k2go.xml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@
4242
one place and primary/secondary never disagree. -->
4343
<item name="materialButtonStyle">@style/Widget.K2Go.Button</item>
4444
<!-- K2GO-439 follow-up: targetSdk 35 forces edge-to-edge and drops the auto status-bar scrim,
45-
so the app must set the system-bar icon contrast itself (Material3 does not default it).
46-
true means a light bar with dark icons. The value is day/night qualified in
47-
values[-night]/bools.xml, the same pattern as the color tokens. -->
45+
so the app must set the status-bar icon contrast itself (Material3 does not default it).
46+
true means a light bar with dark icons. Day/night qualified in values[-night]/bools.xml,
47+
the same pattern as the color tokens. windowLightNavigationBar is not set: the nav bar
48+
renders correctly already, and that attr is API 27 (above the minSdk 24). -->
4849
<item name="android:windowLightStatusBar">@bool/k2go_light_system_bars</item>
49-
<item name="android:windowLightNavigationBar">@bool/k2go_light_system_bars</item>
5050
</style>
5151

5252
<!-- ADFA-5346: shared button shape — official Material 3 fully-rounded (stadium/pill). Change here to

0 commit comments

Comments
 (0)