K2GO-385 refactor(ui): K2GoChip owns the neutral-by-default metadata colour

Second-pass review follow-up on PR3b. The "metadata is neutral" fact was
repeated at every call site (each passed R.color.k2go_muted). Encode it once:
add K2GoChip.create(ctx, text) / style(chip, text) that default to the neutral
tag, and drop the explicit muted at the metadata call sites (DashboardDetail
REST/core/version, ModuleDetail size/version). The 3-arg overloads stay for
valence traits ("Runs offline" = leaf, "Demo" = amber), matching the metadata
colour rule: neutral by default, semantic only for valence.

Author: luisguzman-adfa

controller/app/src/main/java/org/appdevforall/k2go/redesign/DashboardDetailFragment.java

@@ -110,8 +110,8 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
         // System core are neutral metadata tags (colour there is noise -- the metadata colour rule).
         statusChip = K2GoStatusBadge.create(requireContext(), getString(R.string.k2go_dash_chip_checking), R.color.k2go_muted);
         chips.addView(statusChip);
-        chips.addView(K2GoChip.create(requireContext(), getString(R.string.k2go_dash_chip_rest), R.color.k2go_muted));
-        chips.addView(K2GoChip.create(requireContext(), getString(R.string.k2go_dash_chip_core), R.color.k2go_muted));
+        chips.addView(K2GoChip.create(requireContext(), getString(R.string.k2go_dash_chip_rest)));
+        chips.addView(K2GoChip.create(requireContext(), getString(R.string.k2go_dash_chip_core)));
         fetchVersionChip();
 
         ((TextView) root.findViewById(R.id.k2go_moddet_includes_body)).setText(R.string.k2go_dash_includes);
@@ -420,10 +420,10 @@ private void fetchVersionChip() {
             main.post(() -> {
                 if (!isAdded() || chips == null || ver == null) return;
                 if (versionChip == null) {
-                    versionChip = K2GoChip.create(requireContext(), "v" + ver, R.color.k2go_muted);
+                    versionChip = K2GoChip.create(requireContext(), "v" + ver);
                     chips.addView(versionChip, 0);
                 } else {
-                    K2GoChip.style(versionChip, "v" + ver, R.color.k2go_muted);
+                    K2GoChip.style(versionChip, "v" + ver);
                 }
             });
         });

controller/app/src/main/java/org/appdevforall/k2go/redesign/K2GoChip.java

@@ -23,10 +23,26 @@
 import androidx.annotation.ColorRes;
 import androidx.core.content.ContextCompat;
 
+import org.appdevforall.k2go.R;
+
 public final class K2GoChip {
 
     private K2GoChip() {}
 
+    /** The neutral tag colour. Metadata is neutral by default (the metadata colour rule); pass an
+     *  explicit colour to the 3-arg overloads only for a valence trait (e.g. leaf "Runs offline"). */
+    @ColorRes private static final int NEUTRAL = R.color.k2go_muted;
+
+    /** A neutral metadata tag (version, size, "REST API", "System core") -- the common case. */
+    public static TextView create(Context context, CharSequence text) {
+        return create(context, text, NEUTRAL);
+    }
+
+    /** Re-apply a neutral metadata tag's text/colour in place. */
+    public static void style(TextView chip, CharSequence text) {
+        style(chip, text, NEUTRAL);
+    }
+
     /**
      * Build a chip laid out for a horizontal meta-chip row: WRAP content, an 8dp end margin, and
      * the shared outline applied. Callers add it to a {@link LinearLayout} row.

controller/app/src/main/java/org/appdevforall/k2go/redesign/ModuleDetailFragment.java

@@ -72,9 +72,9 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
                 : "\u2248 NA";
         // K2GO-385 (PR3): size / version are neutral metadata tags (colour is noise); "Runs offline" is a
         // leaf trait (a capability that carries valence). The lifecycle status below is a dot+text badge.
-        chips.addView(K2GoChip.create(requireContext(), sizeText, R.color.k2go_muted));
+        chips.addView(K2GoChip.create(requireContext(), sizeText));
         String ver = ModuleCards.version(c.key());
-        if (ver != null) chips.addView(K2GoChip.create(requireContext(), "v" + ver, R.color.k2go_muted));
+        if (ver != null) chips.addView(K2GoChip.create(requireContext(), "v" + ver));
         chips.addView(K2GoChip.create(requireContext(), getString(R.string.k2go_mod_runs_offline), R.color.k2go_leaf));
         if (ModuleCards.isDemo(c.key())) chips.addView(K2GoChip.create(requireContext(), getString(R.string.k2go_mod_demo), R.color.k2go_amber_text));   // ADFA-4958