Skip to content

Commit 13ee09b

Browse files
K2GO-382 fix(ui): review fixes -- keep module-install routing; drop dead home()
Two-pass review of the deep-op notification change: - install() no longer sets EXTRA_INSTALLING. That flag forced LibraryActivity.installing=true, which suppressed the !installing module-queue re-route, so a proot/module install's notification tap stranded on the boot gate instead of the install index. A bare LibraryActivity is correct: a rootfs install is detected by InstallProgressRepository.isRunning(); a module install is forwarded by forActiveOp. - Remove OpReturnNavigator.home(): it was unused (Run-in-background uses SetupProgressActivity.goHome) and was a second builder of the leave-to-Home intent -- the duplicated truth the one-source refactor set out to remove.
1 parent 98728d4 commit 13ee09b

1 file changed

Lines changed: 6 additions & 10 deletions

File tree

‎controller/app/src/main/java/org/appdevforall/k2go/redesign/OpReturnNavigator.java‎

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,13 @@ public static Intent dashboardRebuild(Context ctx) {
6060
.putExtra(SetupLibraryActivity.EXTRA_DASHBOARD_DETAIL, true);
6161
}
6262

63-
/** Rootfs / module install: LibraryActivity shows the rootfs progress (boot gate) and, when a
64-
* proot module queue is live, routes on to the install index (see {@link #forActiveOp}). */
63+
/** Rootfs / module install: a bare LibraryActivity. It detects a live rootfs install itself
64+
* (InstallProgressRepository.isRunning -> the boot-gate progress) and, when a proot module queue
65+
* is live instead, its relaunch re-route ({@link #forActiveOp}) forwards to the install index.
66+
* Do NOT set EXTRA_INSTALLING here: it forces LibraryActivity.installing=true, which suppresses
67+
* that module re-route and would strand a module install's notification on the gate. */
6568
public static Intent install(Context ctx) {
66-
return new Intent(ctx, LibraryActivity.class)
67-
.putExtra(LibraryActivity.EXTRA_INSTALLING, true);
69+
return new Intent(ctx, LibraryActivity.class);
6870
}
6971

7072
/** Clone / share: the Connect/clone tab. */
@@ -73,12 +75,6 @@ public static Intent cloneShare(Context ctx) {
7375
.putExtra(LibraryActivity.EXTRA_TAB, R.id.nav_clone);
7476
}
7577

76-
/** Home / Library -- where "Run in background" lands deliberately (not a back-stack pop). */
77-
public static Intent home(Context ctx) {
78-
return new Intent(ctx, LibraryActivity.class)
79-
.putExtra(LibraryActivity.EXTRA_TAB, R.id.nav_library);
80-
}
81-
8278
/**
8379
* The live op's screen, chosen from the run-state repositories -- the single place that decides
8480
* "which op is running." Returns {@code null} when nothing tracked here is live (the caller keeps

0 commit comments

Comments
 (0)