Repository navigation
Commit f373d50
committed
ADFA-3598: address CodeRabbit review feedback
- PreviewLayoutAction: catch Exception (not Throwable) and log on resource-path
parse failure; derive the layout base path from the last "layout/" segment
instead of substringBefore("layout")
- EditorHandlerActivity: rebuild EDITOR_TOOLBAR plugin actions on plugin disable
so stale PluginToolbarActionItem callbacks are cleared
- IdeProjectServiceImpl: path-validate getModuleContext via isPathAllowed()
- ToolbarAction: document why the provider callbacks stay body vars (ABI compat)
Deferred: permission-gating IdeBuildService.executeTasks needs a per-plugin
permission-aware wrapper + a new build permission (build service is a shared
singleton); to be done as a focused security change.1 parent 664062d commit f373d50
4 files changed
Lines changed: 18 additions & 2 deletions
File tree
- app/src/main/java/com/itsaky/androidide
- actions/etc
- activities/editor
- plugin-api/src/main/kotlin/com/itsaky/androidide/plugins/extensions
- plugin-manager/src/main/kotlin/com/itsaky/androidide/plugins/manager/services
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
| 85 | + | |
85 | 86 | | |
86 | 87 | | |
87 | 88 | | |
| |||
146 | 147 | | |
147 | 148 | | |
148 | 149 | | |
149 | | - | |
| 150 | + | |
150 | 151 | | |
151 | 152 | | |
152 | 153 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
| 95 | + | |
95 | 96 | | |
96 | 97 | | |
97 | 98 | | |
| |||
1269 | 1270 | | |
1270 | 1271 | | |
1271 | 1272 | | |
| 1273 | + | |
| 1274 | + | |
1272 | 1275 | | |
1273 | 1276 | | |
1274 | 1277 | | |
| |||
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
142 | 149 | | |
143 | 150 | | |
144 | 151 | | |
| |||
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
89 | 94 | | |
90 | 95 | | |
91 | 96 | | |
| |||
0 commit comments