refactor(ADFA-4419): distinguish peer-presence overlay from #1448 decorations

Rename EditorDecorationManager -> PeerPresenceOverlayManager and extract a
focused PeerPresenceProvider interface out of the broad EditorProvider, so the
pair-programming peer-cursor overlay (floating named badges) reads as a distinct
concern from the generic EditorDecorationProvider (additive color spans) added
in #1448 (ADFA-4436).

Host-internal only: no plugin-api contract changed and the merged rainbow-
brackets plugin is unaffected. Verified with :app:compileV8DebugKotlin.

Author: alome007

…vities/editor/EditorDecorationManager.kt …ies/editor/PeerPresenceOverlayManager.ktapp/src/main/java/com/itsaky/androidide/activities/editor/EditorDecorationManager.kt renamed to app/src/main/java/com/itsaky/androidide/activities/editor/PeerPresenceOverlayManager.kt app/src/main/java/com/itsaky/androidide/activities/editor/EditorDecorationManager.kt renamed to app/src/main/java/com/itsaky/androidide/activities/editor/PeerPresenceOverlayManager.kt

@@ -18,7 +18,7 @@ import java.io.File
  *
  * All methods must be called on the main thread (the editor view is touched directly).
  */
-class EditorDecorationManager(
+class PeerPresenceOverlayManager(
     private val editorForFile: (File) -> CodeEditor?,
 ) {
 

app/src/main/java/com/itsaky/androidide/app/EditorProviderImpl.kt

@@ -3,7 +3,7 @@ package com.itsaky.androidide.app
 import android.os.Handler
 import android.os.Looper
 import androidx.lifecycle.lifecycleScope
-import com.itsaky.androidide.activities.editor.EditorDecorationManager
+import com.itsaky.androidide.activities.editor.PeerPresenceOverlayManager
 import com.itsaky.androidide.activities.editor.EditorHandlerActivity
 import com.itsaky.androidide.models.Position
 import com.itsaky.androidide.models.Range
@@ -37,7 +37,7 @@ class EditorProviderImpl(
     private val activityRef = WeakReference(activity)
     private val mainHandler = Handler(Looper.getMainLooper())
     private val fileCallbacks = java.util.concurrent.CopyOnWriteArrayList<(File?) -> Unit>()
-    private val decorationManager = EditorDecorationManager { file ->
+    private val peerPresenceOverlay = PeerPresenceOverlayManager { file ->
         activity()?.getEditorForFile(file)?.editor
     }
 
@@ -61,7 +61,7 @@ class EditorProviderImpl(
     fun dispose() {
         EditorEvents.removeFileChangeListener(internalListener)
         fileCallbacks.clear()
-        onMain { decorationManager.clearAll(); true }
+        onMain { peerPresenceOverlay.clearAll(); true }
         activityRef.clear()
     }
 
@@ -270,15 +270,15 @@ class EditorProviderImpl(
         peerName: String,
         peerColor: Int,
     ): Boolean = onMain {
-        decorationManager.addMarker(file, line, column, peerId, peerName, peerColor)
+        peerPresenceOverlay.addMarker(file, line, column, peerId, peerName, peerColor)
     }
 
     override fun hidePeerCursor(file: File, peerId: String): Boolean = onMain {
-        decorationManager.removeMarker(file, peerId)
+        peerPresenceOverlay.removeMarker(file, peerId)
     }
 
     override fun clearPeerCursors(file: File) {
-        onMain { decorationManager.clear(file); true }
+        onMain { peerPresenceOverlay.clear(file); true }
     }
 
     /**

plugin-manager/src/main/kotlin/com/itsaky/androidide/plugins/manager/services/IdeEditorServiceImpl.kt

@@ -26,7 +26,20 @@ class IdeEditorServiceImpl(
         fun getAllowedPaths(): List<String>
     }
 
-    interface EditorProvider {
+    /**
+     * Remote-collaborator presence: draw, move and clear named peer cursors in open editors.
+     * Split out of [EditorProvider] so peer presence is a focused, separately-named contract
+     * rather than three more methods on the broad editor-access surface (interface segregation).
+     * The host bridge implements both through one object. Visual overlay only — never mutates
+     * file content. Each method defaults to a no-op so an implementer can opt in.
+     */
+    interface PeerPresenceProvider {
+        fun showPeerCursor(file: File, line: Int, column: Int, peerId: String, peerName: String, peerColor: Int): Boolean = false
+        fun hidePeerCursor(file: File, peerId: String): Boolean = false
+        fun clearPeerCursors(file: File) {}
+    }
+
+    interface EditorProvider : PeerPresenceProvider {
         fun getCurrentFile(): File?
         fun getOpenFiles(): List<File>
         fun isFileOpen(file: File): Boolean
@@ -54,9 +67,6 @@ class IdeEditorServiceImpl(
         fun insertLineBefore(file: File, line: Int, text: String): Boolean = false
         fun deleteLine(file: File, line: Int): Boolean = false
         fun replaceRange(file: File, range: SelectionRange, newText: String): Boolean = false
-        fun showPeerCursor(file: File, line: Int, column: Int, peerId: String, peerName: String, peerColor: Int): Boolean = false
-        fun hidePeerCursor(file: File, peerId: String): Boolean = false
-        fun clearPeerCursors(file: File) {}
         fun addFileChangeCallback(callback: (File?) -> Unit) {}
         fun removeFileChangeCallback(callback: (File?) -> Unit) {}
     }