ADFA-4436 Use imports and early return in editor decoration code

- Replace fully-qualified EditorDecorationBridge / EditorDecorationProvider
  references with imports across the app and plugin-manager call sites.
- Invert the registration guard in EditorDecorationBridge.init() to an early
  return, dropping a level of nesting while preserving behavior.

Author: hal-eisen-adfa

app/src/main/java/com/itsaky/androidide/app/CredentialProtectedApplicationLoader.kt

@@ -18,6 +18,7 @@ import com.itsaky.androidide.preferences.internal.GeneralPreferences
 import com.itsaky.androidide.resources.localization.LocaleProvider
 import com.itsaky.androidide.ui.themes.IDETheme
 import com.itsaky.androidide.ui.themes.IThemeManager
+import com.itsaky.androidide.utils.EditorDecorationBridge
 import com.itsaky.androidide.utils.Environment
 import com.itsaky.androidide.utils.FeatureFlags
 import com.itsaky.androidide.utils.FileUtil
@@ -329,7 +330,7 @@ internal object CredentialProtectedApplicationLoader : ApplicationLoader {
 			GlobalScope.launch {
 				try {
 					pluginManager?.loadPlugins()
-					com.itsaky.androidide.utils.EditorDecorationBridge.init()
+					EditorDecorationBridge.init()
 					logger.info("Plugin system initialized successfully")
 				} catch (e: Exception) {
 					logger.error("Failed to load plugins", e)
@@ -381,7 +382,7 @@ internal object CredentialProtectedApplicationLoader : ApplicationLoader {
 			}
 		} else if (event.key == GeneralPreferences.UI_MODE && GeneralPreferences.uiMode != AppCompatDelegate.getDefaultNightMode()) {
 			AppCompatDelegate.setDefaultNightMode(GeneralPreferences.uiMode)
-			com.itsaky.androidide.utils.EditorDecorationBridge.refresh()
+			EditorDecorationBridge.refresh()
 		} else if (event.key == GeneralPreferences.SELECTED_LOCALE) {
 			// Use empty locale list if the locale has been reset to 'System Default'
 			val selectedLocale = GeneralPreferences.selectedLocale

app/src/main/java/com/itsaky/androidide/utils/EditorDecorationBridge.kt

@@ -56,25 +56,27 @@ object EditorDecorationBridge {
      */
     @JvmStatic
     fun init() {
-        if (!registered) {
-            registered = true
-            try {
-                val app = BaseApplication.baseInstance
-                lastNightMode = app.resources.configuration.uiMode and Configuration.UI_MODE_NIGHT_MASK
-                app.registerComponentCallbacks(object : ComponentCallbacks {
-                    override fun onConfigurationChanged(newConfig: Configuration) {
-                        val night = newConfig.uiMode and Configuration.UI_MODE_NIGHT_MASK
-                        if (night != lastNightMode) {
-                            lastNightMode = night
-                            refresh()
-                        }
+        if (registered) {
+            refresh()
+            return
+        }
+        registered = true
+        try {
+            val app = BaseApplication.baseInstance
+            lastNightMode = app.resources.configuration.uiMode and Configuration.UI_MODE_NIGHT_MASK
+            app.registerComponentCallbacks(object : ComponentCallbacks {
+                override fun onConfigurationChanged(newConfig: Configuration) {
+                    val night = newConfig.uiMode and Configuration.UI_MODE_NIGHT_MASK
+                    if (night != lastNightMode) {
+                        lastNightMode = night
+                        refresh()
                     }
+                }
 
-                    override fun onLowMemory() {}
-                })
-            } catch (t: Throwable) {
-                log.error("Failed to register editor decoration theme listener", t)
-            }
+                override fun onLowMemory() {}
+            })
+        } catch (t: Throwable) {
+            log.error("Failed to register editor decoration theme listener", t)
         }
         refresh()
     }

app/src/main/java/com/itsaky/androidide/viewmodels/PluginManagerViewModel.kt

@@ -13,6 +13,7 @@ import com.itsaky.androidide.ui.models.PluginManagerUiEffect
 import com.itsaky.androidide.ui.models.PluginManagerUiEvent
 import com.itsaky.androidide.ui.models.PluginManagerUiState
 import com.itsaky.androidide.ui.models.PluginOperation
+import com.itsaky.androidide.utils.EditorDecorationBridge
 import com.itsaky.androidide.utils.UriFileImporter
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.channels.Channel
@@ -123,7 +124,7 @@ class PluginManagerViewModel(
                 }
 
             // Keep the editor decoration providers in sync with the enabled plugin set.
-            com.itsaky.androidide.utils.EditorDecorationBridge.refresh()
+            EditorDecorationBridge.refresh()
 
             _currentOperation.value = PluginOperation.None
         }

plugin-manager/src/main/kotlin/com/itsaky/androidide/plugins/manager/core/PluginManager.kt

@@ -17,6 +17,7 @@ import com.itsaky.androidide.plugins.manager.services.CogoProjectProvider
 import com.itsaky.androidide.plugins.manager.services.IdeTooltipServiceImpl
 import com.itsaky.androidide.plugins.manager.services.IdeEditorTabServiceImpl
 import com.itsaky.androidide.plugins.extensions.DocumentationExtension
+import com.itsaky.androidide.plugins.extensions.EditorDecorationProvider
 import com.itsaky.androidide.plugins.extensions.FileOpenExtension
 import com.itsaky.androidide.plugins.extensions.SnippetExtension
 import com.itsaky.androidide.plugins.manager.services.IdeSnippetServiceImpl
@@ -797,11 +798,11 @@ class PluginManager private constructor(
     /**
      * Get all enabled plugins that provide editor decorations (additive coloring of editor text).
      */
-    fun getEnabledEditorDecorationProviders(): List<com.itsaky.androidide.plugins.extensions.EditorDecorationProvider> {
+    fun getEnabledEditorDecorationProviders(): List<EditorDecorationProvider> {
         return loadedPlugins.values
             .filter { it.isEnabled }
             .map { it.plugin }
-            .filterIsInstance<com.itsaky.androidide.plugins.extensions.EditorDecorationProvider>()
+            .filterIsInstance<EditorDecorationProvider>()
     }
 
     fun notifyFileOpened(file: File) {