Skip to content

Commit c6657e8

Browse files
fryanpanclaude
andcommitted
ADFA-4128: point the two LogSender @disabled reasons at the fix ticket
Both reasons cited only ADFA-5459, which tracks re-enabling the tests. The defect they document (onDebuggableVariants reading variantBuilder.debuggable inside beforeVariants, which AGP rejects for LogSenderPlugin and JdwpPlugin alike) is fixed under ADFA-5433. A reader following the reason now reaches the fix, not only the skip. Review thread: #1722 (comment) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XkGof8cLt23LkxZ8MKzin2
1 parent 46eac1a commit c6657e8

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎gradle-plugin/src/test/java/com/itsaky/androidide/gradle/AndroidIDEInitScriptPluginTest.kt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ class AndroidIDEInitScriptPluginTest {
5252
"callback, which AGP (the repo's current AGP_VERSION_LATEST) forbids with " +
5353
"PropertyAccessNotAllowedException - so enabling LogSender fails to configure ':app' on " +
5454
"both 8.14.3 and 9.5.1. That is a LogSenderPlugin/AGP issue (the known-logsender bucket), " +
55-
"orthogonal to the init-script plugin injection this suite covers. Re-enable once " +
56-
"LogSenderPlugin moves the debuggable read to onVariants (ADFA-5459).",
55+
"orthogonal to the init-script plugin injection this suite covers. The fix (move the read " +
56+
"to onVariants, which also covers JdwpPlugin) is ADFA-5433; re-enabling this test is ADFA-5459.",
5757
)
5858
@ParameterizedTest
5959
@ValueSource(strings = ["8.14.3", "9.5.1"])

‎gradle-plugin/src/test/java/com/itsaky/androidide/gradle/AndroidIDEPluginTest.kt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ class AndroidIDEPluginTest {
3838
"LogSenderPlugin reads ApplicationVariantBuilder.debuggable inside an AGP beforeVariants " +
3939
"callback, which AGP forbids with PropertyAccessNotAllowedException, so enabling " +
4040
"LogSender fails to configure ':app'. Same LogSenderPlugin/AGP issue that disables the " +
41-
"debuggable-variants test in AndroidIDEInitScriptPluginTest; re-enable once " +
42-
"LogSenderPlugin moves the debuggable read to onVariants (ADFA-5459).",
41+
"debuggable-variants test in AndroidIDEInitScriptPluginTest. The fix (move the read to " +
42+
"onVariants, which also covers JdwpPlugin) is ADFA-5433; re-enabling this test is ADFA-5459.",
4343
)
4444
@Test
4545
fun `test logsender must be enabled if specified explicitly`(

0 commit comments

Comments
 (0)