ADFA-4322: Paper-cut: Guide users to enable Display over other apps when blocked by Android restricted settings during onboarding (#1391)

Author: Daniel-ADFA

app/src/main/java/com/itsaky/androidide/fragments/onboarding/PermissionsFragment.kt

@@ -32,6 +32,7 @@ import androidx.core.net.toUri
 import androidx.fragment.app.viewModels
 import androidx.lifecycle.Lifecycle
 import androidx.lifecycle.repeatOnLifecycle
+import androidx.lifecycle.withResumed
 import androidx.recyclerview.widget.RecyclerView
 import com.github.appintro.SlidePolicy
 import com.github.appintro.SlideSelectionListener
@@ -45,6 +46,7 @@ import com.itsaky.androidide.databinding.LayoutOnboardingPermissionsBinding
 import com.itsaky.androidide.events.InstallationEvent
 import com.itsaky.androidide.preferences.internal.prefManager
 import com.itsaky.androidide.tasks.doAsyncWithProgress
+import com.itsaky.androidide.utils.OverlayPermissionGuide
 import com.itsaky.androidide.utils.PermissionsHelper
 import com.itsaky.androidide.utils.flashError
 import com.itsaky.androidide.utils.isTestMode
@@ -73,7 +75,6 @@ class PermissionsFragment :
 	private var recyclerView: RecyclerView? = null
 	private var finishButton: MaterialButton? = null
     private lateinit var pulseAnimation: Animation
-	private var awaitingOverlayGrantResult = false
 
 	private val storagePermissionRequestLauncher =
 		registerForActivityResult(
@@ -97,6 +98,8 @@ class PermissionsFragment :
 		private val logger = LoggerFactory.getLogger(PermissionsFragment::class.java)
 		private const val KEY_PRIVACY_DISCLOSURE_SHOWN = "privacy.disclosure.shown"
 
+		private var awaitingOverlayGrantResult = false
+
 		@JvmStatic
 		fun newInstance(context: Context): PermissionsFragment =
 			PermissionsFragment().apply {
@@ -231,12 +234,13 @@ class PermissionsFragment :
        }
        awaitingOverlayGrantResult = false
 
-       if (PermissionsHelper.canDrawOverlays(requireContext())) {
-          return
+       viewLifecycleScope.launch {
+          viewLifecycleOwner.withResumed {
+             if (!PermissionsHelper.canDrawOverlays(requireContext())) {
+                OverlayPermissionGuide.showRestrictedSettingsDialog(requireContext())
+             }
+          }
        }
-
-       flashError(getString(R.string.permission_overlay_restricted_settings_hint))
-       requestSettingsTogglePermission(Settings.ACTION_APPLICATION_DETAILS_SETTINGS)
     }
 
 	private fun startIdeSetup() {

app/src/main/java/com/itsaky/androidide/utils/OverlayPermissionGuide.kt

@@ -0,0 +1,55 @@
+package com.itsaky.androidide.utils
+
+import android.app.Activity
+import android.content.ActivityNotFoundException
+import android.content.Context
+import android.content.Intent
+import android.net.Uri
+import android.provider.Settings
+import android.text.SpannableStringBuilder
+import com.itsaky.androidide.resources.R
+import org.slf4j.LoggerFactory
+
+object OverlayPermissionGuide {
+
+	private val log = LoggerFactory.getLogger(OverlayPermissionGuide::class.java)
+
+	fun showRestrictedSettingsDialog(context: Context) {
+		val message = SpannableStringBuilder()
+		message.append(context.getString(R.string.permission_overlay_restricted_dialog_message))
+		message.append("\n\n")
+		message.appendOrderedList(*context.resources.getStringArray(R.array.overlay_restricted_settings_steps))
+
+		DialogUtils
+			.newMaterialDialogBuilder(context)
+			.setTitle(R.string.permission_overlay_restricted_dialog_title)
+			.setMessage(message)
+			.setPositiveButton(R.string.permission_overlay_open_app_info) { dialog, _ ->
+				dialog.dismiss()
+				openAppInfo(context)
+			}
+			.setNegativeButton(android.R.string.cancel, null)
+			.show()
+	}
+
+	private fun openAppInfo(context: Context) {
+		val intent = Intent(
+			Settings.ACTION_APPLICATION_DETAILS_SETTINGS,
+			Uri.fromParts("package", context.packageName, null),
+		)
+		if (context !is Activity) {
+			intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
+		}
+		try {
+			context.startActivity(intent)
+		} catch (e: ActivityNotFoundException) {
+			log.error("Failed to open App info settings", e)
+			flashError(
+				context.getString(
+					R.string.err_no_activity_to_handle_action,
+					Settings.ACTION_APPLICATION_DETAILS_SETTINGS,
+				),
+			)
+		}
+	}
+}

resources/src/main/res/values/strings.xml

@@ -722,6 +722,9 @@
 	<string name="permission_desc_overlay_window">Allow Code on the Go to display floating debugger controls to inspect your code while it runs.</string>
 	<string name="permission_overlay_unsupported_hint">Floating debugger is not available on this device.</string>
 	<string name="permission_overlay_restricted_settings_hint">If you can\'t enable this permission, display App info for Code on the Go, tap the three-dot menu, and enable restricted settings.</string>
+	<string name="permission_overlay_restricted_dialog_title">Enable restricted settings</string>
+	<string name="permission_overlay_restricted_dialog_message">Android turned off the “Display over other apps” switch because Code on the Go was installed from outside an app store. To turn it on:</string>
+	<string name="permission_overlay_open_app_info">Open App info</string>
 	<string name="permission_title_notifications">Notifications</string>
 	<string name="permission_desc_notifications">Allow Code on the Go to display notifications.</string>
 	<string name="permission_title_accessibility">Accessibility</string>
@@ -1136,6 +1139,11 @@
 	To use the debugger, you must enable developer options. When you’re ready to pair with the debugger:]]></string>
 
 	<!-- Steps shown to the user in an ordered list in the ADB pairing dialog -->
+	<string-array name="overlay_restricted_settings_steps">
+		<item><![CDATA[On the <b>App info</b> screen, tap the three-dot menu (⋮) in the top corner.]]></item>
+		<item><![CDATA[Tap <b>Allow restricted settings</b>.]]></item>
+		<item><![CDATA[Open <b>Display over other apps</b> and turn it on for Code on the Go.]]></item>
+	</string-array>
 	<string-array name="debugger_setup_pairing_steps">
 		<item><![CDATA[Tap <b>Start pairing</b>. Developer options are displayed.]]></item>
 		<item><![CDATA[Enable <b>Wireless debugging</b>.]]></item>