Repository navigation
Commit bf8aded
committed
ADFA-3418: Tie IDEEditor's EventBus registration to its window
IDEEditor registered with the default EventBus in initEditor() and unregistered only in release(), which a recreate (dark mode, locale) never reaches, so EventBus kept each open editor and the destroyed activity (426 KB in a LeakCanary dump after the breakpoint-listener path was fixed). Register on attach and unregister on detach, as CodeEditorView does.
Chosen over closing editors on recreate: close() posts DocumentCloseEvent through an async dispatcher, which could reach the language server after the recreated activity reopens the same file.1 parent 483c84b commit bf8aded
1 file changed
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
998 | 998 | | |
999 | 999 | | |
1000 | 1000 | | |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
| 1008 | + | |
| 1009 | + | |
| 1010 | + | |
1001 | 1011 | | |
1002 | | - | |
| 1012 | + | |
| 1013 | + | |
| 1014 | + | |
| 1015 | + | |
| 1016 | + | |
1003 | 1017 | | |
1004 | 1018 | | |
1005 | 1019 | | |
| |||
0 commit comments