ADFA-3418: Release editors when the editor activity is recreated

A recreate (dark mode, locale) destroys EditorHandlerActivity without closing its editors, so each editor's EditorEventDispatcher job kept the IDEEditor and the destroyed activity on a coroutine worker (425 KB in a LeakCanary dump), alongside the EventBus and breakpoint-listener paths fixed earlier. preDestroy now calls CodeEditorView.release() on a non-finishing destroy.

release() is close() without notifyClose() - a DocumentCloseEvent could reach the language server after the new activity reopens the file - and without shutting readWriteContext, which an in-flight save may still be writing through.

Author: hal-eisen-adfa

app/src/main/java/com/itsaky/androidide/activities/editor/EditorHandlerActivity.kt

@@ -37,6 +37,7 @@ import androidx.collection.MutableIntObjectMap
 import androidx.core.content.IntentCompat
 import androidx.core.content.res.ResourcesCompat
 import androidx.core.view.GravityCompat
+import androidx.core.view.children
 import androidx.core.view.doOnNextLayout
 import androidx.fragment.app.Fragment
 import androidx.fragment.app.FragmentManager
@@ -264,6 +265,17 @@ open class EditorHandlerActivity :
 	override fun provideEditorAt(index: Int): CodeEditorView? = getEditorAtIndex(index)
 
 	override fun preDestroy() {
+		// A recreate (dark mode, locale) destroys this instance without closing its editors, and their
+		// dispatcher job, EventBus registration and breakpoint listener kept it alive. Finishing closes
+		// them through doCloseAll() instead.
+		if (!isDestroying) {
+			_binding
+				?.content
+				?.editorContainer
+				?.children
+				?.filterIsInstance<CodeEditorView>()
+				?.forEach { it.release() }
+		}
 		super.preDestroy()
 		// TSLanguageRegistry.instance is a process-wide singleton whose own KDoc says destroy() "must
 		// be called only when the application is exiting" -- guarded on didCompleteLiveOnCreate (same

app/src/main/java/com/itsaky/androidide/ui/CodeEditorView.kt

@@ -818,14 +818,20 @@ class CodeEditorView(
 	}
 
 	override fun close() {
+		_binding?.editor?.notifyClose()
+		release()
+		readWriteContext.use { }
+	}
+
+	/**
+	 * Drops what ties this editor to the activity, for a recreate that reopens the same file in a new
+	 * editor. Unlike [close] it neither tells the language server the file closed (that event can land
+	 * after the reopen) nor shuts [readWriteContext], since a save may still be writing through it.
+	 */
+	fun release() {
 		codeEditorScope.cancelIfActive("Cancellation was requested")
 		debugClient.breakpoints.removeListener(this)
-		_binding?.editor?.apply {
-			notifyClose()
-			release()
-		}
-
-		readWriteContext.use { }
+		_binding?.editor?.release()
 	}
 
 	private fun changeFontSizeBy(delta: Float) {