ADFA-4128 (7/11): address CodeRabbit review

- F1719-1 read setup.json arrays type-checked, so parse returns null instead of throwing
- F1719-4 drop the dead telemetry.report import from QuickBuildProjectLayoutTest

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FstXxJ5cwWPcvmhZ9vJgJ7

Author: fryanpan

quickbuild/core/src/main/java/org/appdevforall/cotg/quickbuild/data/ProxyAppInfo.kt

@@ -1,5 +1,6 @@
 package org.appdevforall.cotg.quickbuild.data
 
+import com.google.gson.JsonArray
 import com.google.gson.JsonObject
 import com.google.gson.JsonParser
 import org.appdevforall.cotg.quickbuild.domain.reload.ComponentInfo
@@ -140,15 +141,15 @@ data class ProxyAppInfo(
 
 			val classpath =
 				obj
-					.getAsJsonArray("classpath")
+					.jsonArray("classpath")
 					?.mapNotNull { it.takeIf(com.google.gson.JsonElement::isJsonPrimitive)?.asString }
 					?.map { resolve(it, baseDir) }
 					?: emptyList()
 			// Generated project-scope jars (R.jar and kin) ride the compile classpath:
 			// hot compiles reference R, which the variant compile classpath lacks.
 			val payloadJars =
 				obj
-					.getAsJsonArray("payloadJars")
+					.jsonArray("payloadJars")
 					?.mapNotNull { it.takeIf(com.google.gson.JsonElement::isJsonPrimitive)?.asString }
 					?.map { resolve(it, baseDir) }
 					?: emptyList()
@@ -175,7 +176,7 @@ data class ProxyAppInfo(
 						?.asInt ?: 0,
 				components =
 					obj
-						.getAsJsonArray("components")
+						.jsonArray("components")
 						?.mapNotNull { element -> (element as? JsonObject)?.let(::parseComponent) }
 						?: emptyList(),
 				annotationProcessors = obj.stringArray("annotationProcessors"),
@@ -192,6 +193,20 @@ data class ProxyAppInfo(
 			)
 		}
 
+		/**
+		 * The JSON array under [key], or null when the key is absent, explicitly null, or
+		 * holds something that is not an array.
+		 *
+		 * Gson's `getAsJsonArray` is a raw cast: a scalar, an object or an explicit JSON null
+		 * there throws [ClassCastException]. [parse]'s `runCatching` wraps only the initial
+		 * document parse, so that would escape a function whose own contract is to return
+		 * null. Every other field here is read defensively; this makes the array reads match.
+		 *
+		 * @param key the key to read.
+		 * @return the array, or null rather than a throw for any other shape.
+		 */
+		private fun JsonObject.jsonArray(key: String): JsonArray? = get(key) as? JsonArray
+
 		/**
 		 * A JSON array of strings; empty when the key is absent or not an array.
 		 *
@@ -200,7 +215,7 @@ data class ProxyAppInfo(
 		 *   dropped rather than treated as an error.
 		 */
 		private fun JsonObject.stringArray(key: String): List<String> =
-			getAsJsonArray(key)
+			jsonArray(key)
 				?.mapNotNull { it.takeIf(com.google.gson.JsonElement::isJsonPrimitive)?.asString }
 				?.filter { it.isNotBlank() }
 				?: emptyList()
@@ -256,7 +271,7 @@ data class ProxyAppInfo(
 						?.asBoolean == true,
 				supertypes =
 					obj
-						.getAsJsonArray("supertypes")
+						.jsonArray("supertypes")
 						?.mapNotNull { it.takeIf(com.google.gson.JsonElement::isJsonPrimitive)?.asString }
 						?: emptyList(),
 			)

quickbuild/core/src/test/java/org/appdevforall/cotg/quickbuild/data/ProxyAppInfoEdgeTest.kt

@@ -23,6 +23,45 @@ class ProxyAppInfoEdgeTest {
 		}
 		""".trimIndent()
 
+	@Test
+	fun `an array key holding a scalar is ignored, not a crash`() {
+		// getAsJsonArray is a raw cast in Gson, and parse's runCatching covers only the
+		// initial document parse - so a hand-edited or older setup.json used to throw
+		// ClassCastException out of a function whose contract is to return null.
+		val text = json(""","classpath": "/libs/one.jar", "sourceRoots": 7""")
+
+		val info = ProxyAppInfo.parse(text, baseDir)
+
+		assertThat(info).isNotNull()
+		assertThat(info!!.classpath).isEmpty()
+		assertThat(info.sourceRoots).isEmpty()
+	}
+
+	@Test
+	fun `an explicit JSON null array key is ignored, not a crash`() {
+		val text = json(""","components": null, "payloadJars": null""")
+
+		val info = ProxyAppInfo.parse(text, baseDir)
+
+		assertThat(info).isNotNull()
+		assertThat(info!!.components).isEmpty()
+		assertThat(info.classpath).isEmpty()
+	}
+
+	@Test
+	fun `a component whose supertypes key is an object is ignored, not a crash`() {
+		val text =
+			json(
+				""","components": [{"type":"activity","userClass":"com.example.Main",""" +
+					""""supertypes": {"0": "android.app.Activity"}}]""",
+			)
+
+		val info = ProxyAppInfo.parse(text, baseDir)
+
+		assertThat(info).isNotNull()
+		assertThat(info!!.components.single().supertypes).isEmpty()
+	}
+
 	@Test
 	fun `non-JSON text parses to null`() {
 		assertThat(ProxyAppInfo.parse("not json at all", baseDir)).isNull()

quickbuild/core/src/test/java/org/appdevforall/cotg/quickbuild/data/QuickBuildProjectLayoutTest.kt

@@ -1,7 +1,6 @@
 package org.appdevforall.cotg.quickbuild.data
 
 import com.google.common.truth.Truth.assertThat
-import org.appdevforall.cotg.quickbuild.service.telemetry.report
 import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.io.TempDir
 import java.io.File