ADFA-1179: Display editor toolbar menu items in a scroll view (#322)

* WIP(ADFA-307): create custom toolbar

* fix (ADFA-307): remove duplicate menu items

* feat(ADFA-307): Add arrows to the start and end of the scrollview

* feat(ADFA-307): Replace extended toolbar with custom toolbar

* feat(ADFA-1179): Remove app name from editor toolbar

Remove "Code on the Go" from editor toolbar and display just the current project's name

* feat(ADFA-1179): Replace double arrows with single arrows

* feat(ADFA-1179): Handle find action

* Show a dialog when "Find" menu is clicked
* Implement "FindInFile" and "FindInProject" actions

* fix(ADFA-1179): UI fixes in toolbar menu

* refactor(ADFA-1179): Remove hardcoded text

* refactor(ADFA-1179): Remove unnecessary context addition

* refactor(ADFA-1179): Rename variable name

Change "shouldMarkInvisible" to "shouldHideFindInFileAction"

* refactor(ADFA-1179): Remove redundant variable declaration

* refactor(ADFA-1179): Remove usages of ExtendedMenuToolbar

* fix(ADFA-1179): Set image color tint based on device theme

* refactor(ADFA-1179): Reorder editor toolbar menu items

* feat(ADFA-1179): Update menu items when app state changes

* fix(ADFA-1179): Always show chevrons

* fix(ADFA-1179): Remove end margin from last action item

* fix(ADFA-1179): Use cancel build icon while build is in progress only for quick run action

Both QuickRunAction and DebugAction implement AbstractCancellableRunAction which sets the action item icon to "stop_daemons" icon. This is not needed for DebugAction.

* fix(ADFA-1179): Disable debug action when build is in progress

* feat(ADFA-1179): Remove git icons from toolbar

* fix(ADFA-1179): Resolve issue with project name's text color in dark mode

* refactor(ADFA-1179): Remove manual action execution

* refactor(ADFA-1179): Replace findViewById with view binding

* refactor(ADFA-1179): Use current theme attributes

* fix(ADFA-1179): Prevent project title from overlapping toolbar actions

* fix(ADFA-1179): Disable find action if build is in progress

* fix(ADFA-1179): Execute actions only when item is enabled

* fix(ADFA-1179): Fix issue with quick run action

* refactor(ADFA-1179): Rename find action item location

* refactor(ADFA-1179): Use theme-defined colors

* fix: extract action IDs to constants

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

---------

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>
Co-authored-by: Akash Yadav <akashyadav@appdevforall.org>

Author: dara-abijo-adfa

actions/src/main/java/com/itsaky/androidide/actions/ActionItem.kt

@@ -158,6 +158,11 @@ interface ActionItem {
     /** Location marker for action items shown in editor activity's toolbar. */
     EDITOR_TOOLBAR("ide.editor.toolbar"),
 
+    /** Location marker for action items shown in editor activity's toolbar submenu.
+     * FindInFileAction and FindInProjectAction will use this location so
+     * they don't show in the editor activity's toolbar*/
+    EDITOR_FIND_ACTION_MENU("ide.editor.toolbar.find.menu"),
+
     /**
      * Location marker for action items shown in editor activity's sidebar (navigation rail in the drawer).
      */

app/src/main/java/com/itsaky/androidide/actions/build/AbstractCancellableRunAction.kt

@@ -40,7 +40,9 @@ abstract class AbstractCancellableRunAction(
             return
         }
 
-        if (data.getActivity().isBuildInProgress()) {
+        if (data.getActivity()
+                .isBuildInProgress() && id == QuickRunAction.ID
+        ) {
             label = context.getString(R.string.title_cancel_build)
             icon = ContextCompat.getDrawable(context, R.drawable.ic_stop_daemons)
         } else {
@@ -94,7 +96,8 @@ abstract class AbstractCancellableRunAction(
 
     companion object {
         @JvmStatic
-        protected val log: Logger = LoggerFactory.getLogger(AbstractCancellableRunAction::class.java)
+        protected val log: Logger =
+            LoggerFactory.getLogger(AbstractCancellableRunAction::class.java)
 
         fun EditorHandlerActivity?.isBuildInProgress(): Boolean {
             val buildService = Lookup.getDefault().lookup(BuildService.KEY_BUILD_SERVICE)

app/src/main/java/com/itsaky/androidide/actions/build/DebugAction.kt

@@ -37,12 +37,8 @@ class DebugAction(
 
     override fun prepare(data: ActionData) {
         super.prepare(data)
-        if (data.getActivity().isBuildInProgress()) {
-            // if a build is in progress, then the 'Quick run' action will be used to
-            // show the cancellation button
-            visible = false
-        }
-        enabled = JdwpOptions.JDWP_ENABLED
+        val buildIsInProgress = data.getActivity().isBuildInProgress()
+        enabled = JdwpOptions.JDWP_ENABLED && !buildIsInProgress
     }
 
     override fun onCreateTaskExecMessage(

app/src/main/java/com/itsaky/androidide/actions/build/ProjectSyncAction.kt

@@ -31,9 +31,13 @@ import com.itsaky.androidide.resources.R.string
  */
 class ProjectSyncAction(context: Context, override val order: Int) : BaseBuildAction() {
 
-  override val id: String = "ide.editor.syncProject"
+  override val id: String = ID
   override var requiresUIThread = false
 
+  companion object {
+    const val ID = "ide.editor.syncProject"
+  }
+
   init {
     label = context.getString(string.title_sync_project)
     icon = ContextCompat.getDrawable(context, R.drawable.ic_sync)

app/src/main/java/com/itsaky/androidide/actions/build/QuickRunAction.kt

@@ -46,7 +46,11 @@ class QuickRunAction(context: Context, override val order: Int) :
         iconRes = R.drawable.ic_run_outline
     ) {
 
-    override val id: String = "ide.editor.build.quickRun"
+    override val id: String = ID
+
+    companion object {
+        const val ID = "ide.editor.build.quickRun"
+    }
 
     override fun onCreateTaskExecMessage(
         data: ActionData,

app/src/main/java/com/itsaky/androidide/actions/build/RunTasksAction.kt

@@ -26,9 +26,13 @@ import com.itsaky.androidide.resources.R
 
 /** @author Akash Yadav */
 class RunTasksAction(context: Context, override val order: Int) : BaseBuildAction() {
-  override val id: String = "ide.editor.build.runTasks"
+  override val id: String = ID
   private var dialog: RunTasksDialogFragment? = null
 
+  companion object {
+    const val ID = "ide.editor.build.runTasks"
+  }
+
   init {
     label = context.getString(R.string.title_run_tasks)
     icon = ContextCompat.getDrawable(context, R.drawable.ic_run_tasks)

…androidide/actions/etc/FindActionMenu.kt …aky/androidide/actions/etc/FindAction.ktapp/src/main/java/com/itsaky/androidide/actions/etc/FindActionMenu.kt renamed to app/src/main/java/com/itsaky/androidide/actions/etc/FindAction.kt app/src/main/java/com/itsaky/androidide/actions/etc/FindActionMenu.kt renamed to app/src/main/java/com/itsaky/androidide/actions/etc/FindAction.kt

@@ -20,28 +20,36 @@ package com.itsaky.androidide.actions.etc
 import android.content.Context
 import androidx.core.content.ContextCompat
 import com.itsaky.androidide.actions.ActionData
-import com.itsaky.androidide.actions.ActionItem
-import com.itsaky.androidide.actions.ActionMenu
 import com.itsaky.androidide.actions.EditorActivityAction
+import com.itsaky.androidide.actions.build.AbstractCancellableRunAction.Companion.isBuildInProgress
 import com.itsaky.androidide.resources.R
 
 /** @author Akash Yadav */
-class FindActionMenu(context: Context, override val order: Int) : EditorActivityAction(),
-  ActionMenu {
+class FindAction() : EditorActivityAction() {
 
-  override val children: MutableSet<ActionItem> = mutableSetOf()
-  override val id: String = "ide.editor.find"
+    override var requiresUIThread: Boolean = true
+    override var order: Int = 0
 
-  init {
-    label = context.getString(R.string.menu_find)
-    icon = ContextCompat.getDrawable(context, R.drawable.ic_search)
+    constructor(context: Context, order: Int) : this() {
+        this.label = context.getString(R.string.menu_find)
+        this.icon = ContextCompat.getDrawable(context, R.drawable.ic_search)
+        this.order = order
+    }
 
-    addAction(FindInFileAction(context, 0))
-    addAction(FindInProjectAction(context, 1))
-  }
+    override val id: String = "ide.editor.find"
 
-  override fun prepare(data: ActionData) {
-    super<EditorActivityAction>.prepare(data)
-    super<ActionMenu>.prepare(data)
-  }
+    override fun prepare(data: ActionData) {
+        super.prepare(data)
+        enabled = data.getActivity().isBuildInProgress().not()
+    }
+
+    override suspend fun execAction(data: ActionData): Boolean {
+        val context = data.getActivity() ?: return false
+        val dialog = context.findActionDialog(data)
+
+        return run {
+            dialog.show()
+            true
+        }
+    }
 }

app/src/main/java/com/itsaky/androidide/actions/etc/FindInFileAction.kt

@@ -20,6 +20,7 @@ package com.itsaky.androidide.actions.etc
 import android.content.Context
 import androidx.core.content.ContextCompat
 import com.itsaky.androidide.actions.ActionData
+import com.itsaky.androidide.actions.ActionItem
 import com.itsaky.androidide.actions.EditorRelatedAction
 import com.itsaky.androidide.resources.R
 
@@ -28,6 +29,7 @@ class FindInFileAction() : EditorRelatedAction() {
 
   override val id: String = "ide.editor.find.inFile"
   override var requiresUIThread: Boolean = true
+  override var location: ActionItem.Location = ActionItem.Location.EDITOR_FIND_ACTION_MENU
 
   override var order: Int = 0
 

app/src/main/java/com/itsaky/androidide/actions/etc/FindInProjectAction.kt

@@ -20,6 +20,7 @@ package com.itsaky.androidide.actions.etc
 import android.content.Context
 import androidx.core.content.ContextCompat
 import com.itsaky.androidide.actions.ActionData
+import com.itsaky.androidide.actions.ActionItem
 import com.itsaky.androidide.actions.EditorActivityAction
 import com.itsaky.androidide.actions.markInvisible
 import com.itsaky.androidide.projects.IProjectManager
@@ -30,6 +31,7 @@ class FindInProjectAction() : EditorActivityAction() {
 
   override var requiresUIThread: Boolean = true
   override var order: Int = 0
+  override var location: ActionItem.Location = ActionItem.Location.EDITOR_FIND_ACTION_MENU
 
   constructor(context: Context, order: Int) : this() {
     this.label = context.getString(R.string.menu_find_project)