Repository navigation
Commit 78cb1c6
ADFA-4128: qb 03 review fixes — align tool-path DTO test with contract
Finding (Important, pr03-review.md): DaemonProtocolDtoTest's first test was
named "configure without optional toolchain paths means self-discovery" with a
comment calling null the "discover from ANDROID_HOME" signal — the opposite of
the contract in the same commit (DaemonProtocol.kt KDoc: "required, as the
daemon never guesses a tool path"; README: configure answers ok:false with one
diagnostic per missing field) and of the daemon's actual behavior at stack tip
(DaemonService.configure rejects null/blank aapt2/d8Jar/androidJar).
Fix: renamed the test and rewrote the comment so null reads as "not supplied,
and configure rejects it", per the documented contract. The assertions were
already correct (null IS the DTO default) and are unchanged; the rejection
behavior itself is asserted in the daemon module's DaemonServiceTest at stack
tip, so no rejection assertion is duplicated here.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Kj9YeCDHGp9DU8LPtfWJ7W1 parent 232fb38 commit 78cb1c6
1 file changed
Lines changed: 3 additions & 2 deletions
File tree
- quickbuild/protocol/src/test/kotlin/org/appdevforall/cotg/quickbuild/protocol
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
0 commit comments