Repository navigation
Commit 7376fb8
fix(editor): address review feedback on a11y cursor sync
- getAccessibilityClassName() now mirrors the !isReleased && isEnabled &&
isEditable guard used by createAccessibilityNodeInfo(), so a read-only or
released editor is no longer announced as an "Edit box".
- Word granularity navigation snaps a mid-word offset to the enclosing word's
start/end, so navigation traverses the whole word (e.g. "hello"@2 -> [0,5])
instead of a truncated range. Adds regression tests for mid-word offsets.
- Narrow the accessibility catch blocks to IndexOutOfBoundsException /
IllegalArgumentException instead of a broad Exception, per project convention.1 parent feb5bd5 commit 7376fb8
3 files changed
Lines changed: 37 additions & 3 deletions
File tree
- editor/src
- main/java/com/itsaky/androidide/editor
- ui
- utils
- test/java/com/itsaky/androidide/editor/utils
Lines changed: 16 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
651 | 651 | | |
652 | 652 | | |
653 | 653 | | |
654 | | - | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
655 | 662 | | |
656 | 663 | | |
657 | 664 | | |
| |||
713 | 720 | | |
714 | 721 | | |
715 | 722 | | |
716 | | - | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
717 | 727 | | |
718 | 728 | | |
719 | 729 | | |
| |||
796 | 806 | | |
797 | 807 | | |
798 | 808 | | |
799 | | - | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
800 | 813 | | |
801 | 814 | | |
802 | 815 | | |
| |||
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
126 | 131 | | |
127 | 132 | | |
128 | 133 | | |
| |||
138 | 143 | | |
139 | 144 | | |
140 | 145 | | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
141 | 151 | | |
142 | 152 | | |
143 | 153 | | |
| |||
Lines changed: 11 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
85 | 96 | | |
86 | 97 | | |
87 | 98 | | |
| |||
0 commit comments