ADFA-4592: Stop wiping app/build every debug build to restore incremental compiles (#1492)

The debug.yml workflow wiped the whole :app module build dir on every run
via two 'rm -rf app/build/' steps, forcing a full recompile+redex of the
~51K-LOC :app module each build and masking the build-time savings from
migrating features into plugins.

- Remove the pre-assembly 'Clean build cache before assembly' step (added as
  a workaround for stale-DEX D8 crashes from the now-removed llama/agent
  custom dexing path).
- Narrow the post-upload cleanup from 'rm -rf app/build/' to
  'rm -rf app/build/outputs/apk/' so a stale APK is never selected while the
  compiled :app intermediates are preserved for incremental builds.
- Remove the dead registerD8Task function and its unused FileNotFoundException
  import / top-level isWindows helper from app/build.gradle.kts.

Author: hal-eisen-adfa

.github/workflows/debug.yml

@@ -134,12 +134,6 @@ jobs:
         run: |
           flox activate -d flox/base -- ./gradlew :plugin-api:apiCheck --no-daemon
 
-      - name: Clean build cache before assembly
-        run: |
-          echo "Cleaning stale build artifacts..."
-          rm -rf app/build/
-          echo "Build cache cleaned successfully"
-
       - name: Assemble Universal APK
         run: |
           echo "gradle_time_start=$(date +%s)" >> $GITHUB_ENV
@@ -383,11 +377,14 @@ jobs:
             exit 1
           fi
 
-      - name: Clean up build folder after upload
+      - name: Clean up APK output after upload
         run: |
-          echo "Cleaning up build folder after Firebase upload..."
-          rm -rf app/build/
-          echo "Build folder cleanup completed"
+          echo "Removing built APK(s) after Firebase upload..."
+          # Only remove the packaged APKs (prevents 'Find APK file' from picking a
+          # stale APK on the next run). Compiled intermediates are preserved so the
+          # next build compiles :app incrementally instead of from scratch.
+          rm -rf app/build/outputs/apk/
+          echo "APK output cleanup completed"
 
       - name: Send Rich Slack Notification
         env:

app/build.gradle.kts

@@ -9,7 +9,6 @@ import org.json.JSONObject
 import java.io.BufferedInputStream
 import java.io.BufferedOutputStream
 import java.io.FileInputStream
-import java.io.FileNotFoundException
 import java.io.FileOutputStream
 import java.net.HttpURLConnection
 import java.net.URI
@@ -27,39 +26,6 @@ import java.util.zip.ZipInputStream
 import java.util.zip.ZipOutputStream
 import kotlin.reflect.jvm.javaMethod
 
-val isWindows = System.getProperty("os.name").lowercase().contains("windows")
-
-fun TaskContainer.registerD8Task(
-	taskName: String,
-	inputJar: File,
-	outputDex: File,
-): org.gradle.api.tasks.TaskProvider<Exec> {
-	val androidSdkDir = android.sdkDirectory.absolutePath
-	val buildToolsVersion = android.buildToolsVersion // Gets the version from your project
-	val d8Executable =
-		File(
-			"$androidSdkDir/build-tools/$buildToolsVersion/" +
-				if (isWindows) "d8.bat" else "d8",
-		)
-
-	if (!d8Executable.exists()) {
-		throw FileNotFoundException("D8 executable not found at: ${d8Executable.absolutePath}")
-	}
-
-	return register<Exec>(taskName) {
-		inputs.file(inputJar)
-		outputs.file(outputDex)
-
-		commandLine(
-			d8Executable.absolutePath,
-			"--release", // Enables optimizations
-			"--output",
-			outputDex.parent, // D8 outputs to a directory
-			inputJar.absolutePath,
-		)
-	}
-}
-
 plugins {
 	id("com.android.application")
 	id("kotlin-android")