Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo Workbench schemas should support subgraph linting #114

Open
spurrkins opened this issue Sep 28, 2021 · 2 comments
Open

Apollo Workbench schemas should support subgraph linting #114

spurrkins opened this issue Sep 28, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@spurrkins
Copy link

It doesn't seem to be possible to lint a subgraph, which would be very helpful for fixing formatting after accumulating errors from copying schema bits around.

@spurrkins spurrkins changed the title Apollo Workbench schemas should support linting Apollo Workbench schemas should support subgraph linting Sep 28, 2021
@michael-watson
Copy link
Collaborator

@spurrkins I definitely agree with this but I've come up short on this in my first pass. One path I'm exploring is having workbench point at .graphql schema files that would be used instead of storing the schema in a giant file. This would enable local editor formatting rules to be applied, but that really primarily covers VS Code users. Two questions I have for you on this:

  1. Are you primarily a VS code user? I've been exploring the idea of separating some of this stuff out into a CLI that would make "Apollo Workbench" friendly outside of VS Code.
  2. How would you like to see your linting applied? Is this logic currently in subgraph repositories that already exists and you would like to "apply" that linting to a subgraph in workbench? Would you like to just use the schema in that repository directly instead?

@michael-watson michael-watson self-assigned this Dec 29, 2021
@michael-watson michael-watson added the question Further information is requested label Dec 29, 2021
@michael-watson
Copy link
Collaborator

I do want to add linting in a future release. Currently you can run GraphOS schema checks that include linting results, but no way to "apply" the linting to fix the schema (or at least provide errors in the problems panel).

For formatting, I utilize the other Apollo VS Code Extension and it provides some formatting.

I'm going to keep this issue open, but this feature isn't currently planned.

@michael-watson michael-watson added enhancement New feature or request help wanted Extra attention is needed labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants