Merge pull request #86 from apisearch-io/fix/fixed-filters-without-array-in-values

Filter values MUST be an array

Author: mmoreram

Query/Filter.php

@@ -15,6 +15,7 @@
 
 namespace Apisearch\Query;
 
+use Apisearch\Exception\InvalidFormatException;
 use Apisearch\Model\HttpTransportable;
 
 /**
@@ -278,6 +279,13 @@ public function toArray(): array
      */
     public static function createFromArray(array $array): self
     {
+        if (
+            isset($array['values']) &&
+            !is_array($array['values'])
+        ) {
+            throw InvalidFormatException::queryFormatNotValid($array);
+        }
+
         return self::create(
             $array['field'] ?? 'uuid.type',
             $array['values'] ?? [],

Tests/Query/FilterTest.php

@@ -15,6 +15,7 @@
 
 namespace Apisearch\Tests\Query;
 
+use Apisearch\Exception\InvalidFormatException;
 use Apisearch\Query\Filter;
 use PHPUnit\Framework\TestCase;
 
@@ -119,4 +120,19 @@ public function testCreateFromArrayWithDefaults()
         $this->assertEquals(Filter::TYPE_FIELD, $aggregation->getFilterType());
         $this->assertEquals([], $aggregation->getFilterTerms());
     }
+
+    /**
+     * Test wrong values format.
+     */
+    public function testWrongValuesFormat()
+    {
+        try {
+            Filter::createFromArray([
+                'values' => 'string',
+            ]);
+            $this->fail('InvalidFormatException should be thrown');
+        } catch (InvalidFormatException $exception) {
+            // Silent pass
+        }
+    }
 }

Tests/Result/ResultTest.php

@@ -196,7 +196,7 @@ public function testCreateFromArrayAllValues()
     }
 
     /**
-     * Test multi result
+     * Test multi result.
      */
     public function testMultiResult()
     {