Merge pull request #49 from apisearch-io/fix/added-aggregation-checks

Exception when wrong aggregation name

Author: mmoreram

Query/Aggregation.php

@@ -15,6 +15,7 @@
 
 namespace Apisearch\Query;
 
+use Apisearch\Exception\InvalidFormatException;
 use Apisearch\Model\HttpTransportable;
 
 /**
@@ -283,6 +284,10 @@ public function toArray(): array
      */
     public static function createFromArray(array $array): self
     {
+        if (empty($array['name'])) {
+            throw InvalidFormatException::queryFormatNotValid($array);
+        }
+
         return self::create(
             $array['name'],
             $array['field'] ?? 'uuid.type',

Tests/Query/AggregationTest.php

@@ -48,6 +48,28 @@ public function testCreate()
         $this->assertEquals(10, $aggregation->getLimit());
     }
 
+    /**
+     * Test creation with bad name.
+     *
+     * @expectedException \Apisearch\Exception\InvalidFormatException
+     */
+    public function testCreateBadName()
+    {
+        Aggregation::createFromArray([]);
+    }
+
+    /**
+     * Test creation with empty name.
+     *
+     * @expectedException \Apisearch\Exception\InvalidFormatException
+     */
+    public function testCreateEmptyName()
+    {
+        Aggregation::createFromArray([
+            'name' => '',
+        ]);
+    }
+
     /**
      * Test creation with default values.
      */