Skip to content

Commit 0146c63

Browse files
authored
Merge pull request #95 from apisearch-io/fix/fixed-searchable-fields-naming
Fixed field name from filter_fields to searchable_fields
2 parents bced14e + ed584d1 commit 0146c63

File tree

2 files changed

+22
-9
lines changed

2 files changed

+22
-9
lines changed

Query/Query.php

+9-9
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,9 @@ class Query implements HttpTransportable
165165
/**
166166
* @var string[]
167167
*
168-
* Filter fields
168+
* Searchable fields
169169
*/
170-
private $filterFields = [];
170+
private $searchableFields = [];
171171

172172
/**
173173
* @var ScoreStrategies
@@ -720,13 +720,13 @@ public function filterUniverseByLocation(LocationRange $locationRange): self
720720
/**
721721
* Set filter fields.
722722
*
723-
* @param string[] $filterFields
723+
* @param string[] $searchableFields
724724
*
725725
* @return Query
726726
*/
727-
public function setFilterFields(array $filterFields)
727+
public function setsearchableFields(array $searchableFields)
728728
{
729-
$this->filterFields = $filterFields;
729+
$this->searchableFields = $searchableFields;
730730

731731
return $this;
732732
}
@@ -736,9 +736,9 @@ public function setFilterFields(array $filterFields)
736736
*
737737
* @return string[]
738738
*/
739-
public function getFilterFields(): array
739+
public function getsearchableFields(): array
740740
{
741-
return $this->filterFields;
741+
return $this->searchableFields;
742742
}
743743

744744
/**
@@ -1489,7 +1489,7 @@ public function toArray(): array
14891489
'aggregations_enabled' => $this->aggregationsEnabled
14901490
? null
14911491
: false,
1492-
'filter_fields' => $this->filterFields,
1492+
'searchable_fields' => $this->searchableFields,
14931493
'score_strategies' => $this->scoreStrategies instanceof ScoreStrategies
14941494
? $this->scoreStrategies->toArray()
14951495
: null,
@@ -1568,7 +1568,7 @@ public static function createFromArray(array $array): self
15681568
return ItemUUID::createFromArray($itemUUID);
15691569
}, $array['items_promoted'] ?? []));
15701570
$query->fuzziness = $array['fuzziness'] ?? null;
1571-
$query->filterFields = $array['filter_fields'] ?? [];
1571+
$query->searchableFields = $array['searchable_fields'] ?? [];
15721572
$query->scoreStrategies = isset($array['score_strategies'])
15731573
? ScoreStrategies::createFromArray($array['score_strategies'])
15741574
: null;

Tests/Query/QueryTest.php

+13
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ public function testDefaults()
7373
$this->assertEquals($query, HttpHelper::emulateHttpTransport($query));
7474
$this->assertNull($query->getUUID());
7575
$this->assertNull($query->getIndexUUID());
76+
$this->assertEquals([], $query->getsearchableFields());
7677
}
7778

7879
/**
@@ -218,4 +219,16 @@ public function testIndexUUID()
218219
$this->assertEquals($indexUUID, $query->getIndexUUID());
219220
$this->assertEquals($indexUUID->toArray(), $query->toArray()['index_uuid']);
220221
}
222+
223+
/**
224+
* Test searchable fields.
225+
*/
226+
public function testSearchableFields()
227+
{
228+
$query = Query::createMatchAll()->setsearchableFields(['field1']);
229+
$this->assertEquals(['field1'], $query->getsearchableFields());
230+
$this->assertEquals(['field1'], $query->toArray()['searchable_fields']);
231+
$query = HttpHelper::emulateHttpTransport($query);
232+
$this->assertEquals(['field1'], $query->getsearchableFields());
233+
}
221234
}

0 commit comments

Comments
 (0)