Update eslint packages (#375)

* chore: update the eslint packages

* chore: run eslint --fix

* chore: ignore new eslint rules

* fix: move `eslint-disable` comments into scope

* chore: empty commit to trigger build

Author: Kristján Oddsson

README.md

@@ -24,7 +24,7 @@ To run the project locally, first clone this repository...
 $ git clone https://github.com/apis-is/apis.git
 ```
 
-... install the dependencies and run the project.
+.... install the dependencies and run the project.
 
 ```sh
 $ npm install

config/index.js

@@ -1,3 +1,5 @@
+/* eslint-disable import/no-dynamic-require */
+/* eslint-disable global-require */
 import _ from 'lodash'
 import makeDebug from 'debug'
 import defaultConfig from './default.json'

endpoints/address/graphql_schema.js

@@ -44,6 +44,6 @@ export default {
   },
   resolve: (_, args) => {
     const address = args.address.replace(' ', '+')
-    return lookupAddresses(address).then((data) => data, (error) => error)
+    return lookupAddresses(address).then(data => data, error => error)
   },
 }

endpoints/address/index.js

@@ -1,9 +1,10 @@
+/* eslint-disable import/first */
 import request from 'request'
 import h from 'apis-helpers'
 import app from '../../server'
 import _ from 'lodash'
 
-const lookupAddresses = (address) => new Promise((resolve, reject) => {
+const lookupAddresses = address => new Promise((resolve, reject) => {
   request.get({
     headers: { 'User-Agent': h.browser() },
     url: `https://api.postur.is/PosturIs/ws.asmx/GetPostals?address=${address}`,
@@ -13,11 +14,9 @@ const lookupAddresses = (address) => new Promise((resolve, reject) => {
     }
 
     // There is a enclosing () in the response
-    const data = _.flatten(
-      JSON.parse(body.replace(/[()]/g, ''))
-    )
+    const data = _.flatten(JSON.parse(body.replace(/[()]/g, '')))
 
-    const results = _.map(data, (elem) => ({
+    const results = _.map(data, elem => ({
       street: elem.Gata,
       house: elem.Husnumer,
       zip: elem.Postnumer,
@@ -41,8 +40,8 @@ app.get('/address/:address?', (req, res) => {
   }
 
   lookupAddresses(address).then(
-    (results) => res.cache().json({ results }),
-    () => res.status(500).json({ error: 'www.postur.is refuses to respond or give back data' })
+    results => res.cache().json({ results }),
+    () => res.status(500).json({ error: 'www.postur.is refuses to respond or give back data' }),
   )
 })
 

endpoints/aur/index.js

@@ -31,15 +31,15 @@ function queryHistory(callback) {
   // default is "1mon", "ytd" is from last new years eve to present
   queryGzipJson(
     'https://isx.is/api/historical-prices?currency=isk&market=aur&timeframe=1year',
-    callback
+    callback,
   )
 }
 
 function queryTransactions(callback) {
   // set limit to OVER 9000
   queryGzipJson(
     'https://isx.is/api/transactions?currency=isk&market=aur&limit=9001',
-    callback
+    callback,
   )
 }
 

endpoints/aur/tests/integration_test.js

@@ -1,3 +1,6 @@
+/* eslint-disable no-bitwise */
+/* eslint-disable import/first */
+/* eslint-disable import/extensions */
 import request from 'request'
 import helpers from '../../../lib/test_helpers.js'
 import assert from 'assert'
@@ -44,11 +47,11 @@ describe('stats', function () {
       helpers.assertTypesOfFields(statsFieldsType, [json])
       assert(
         ~transactionTypes.indexOf(json.last_transaction_type),
-        `Unexpected transaction type '${json.last_transaction_type}'`
+        `Unexpected transaction type '${json.last_transaction_type}'`,
       )
       assert(
         moment(json.timestampApis, timestampFormat, true).isValid(),
-        `Unexpected timestamp format, ${json.timestampApis}' does not match ${timestampFormat}`
+        `Unexpected timestamp format, ${json.timestampApis}' does not match ${timestampFormat}`,
       )
       done()
     })
@@ -81,21 +84,21 @@ describe('history', function () {
       helpers.assertTypesOfFields(historyFieldsType, json.results)
       assert(
         json.currency.constructor === String,
-        'Unexpected currency type, should be String'
+        'Unexpected currency type, should be String',
       )
       assert(
         json.market.constructor === String,
-        'Unexpected market type, should be String'
+        'Unexpected market type, should be String',
       )
       assert(
         moment(json.timestampApis, timestampFormat, true).isValid(),
-        `Unexpected timestamp format, '${json.timestampApis}' does not match ${timestampFormat}`
+        `Unexpected timestamp format, '${json.timestampApis}' does not match ${timestampFormat}`,
       )
       json.results.forEach((result, i) => {
         assert(
           moment(result.date, dateFormat, true).isValid(),
           (`Unexpected date format in result #${i};` +
-          ` '${result.date}' does not match ${dateFormat}`)
+          ` '${result.date}' does not match ${dateFormat}`),
         )
       })
       done()
@@ -131,12 +134,12 @@ describe('transactions', function () {
       json.results.forEach((result, i) => {
         assert(
           ~transactionTypes.indexOf(result.type),
-          `Unexpected transaction type '${result.type}' in result #${i}`
+          `Unexpected transaction type '${result.type}' in result #${i}`,
         )
         assert(
           moment(result.timestamp, timestampFormat, true).isValid(),
           (`Unexpected timestamp format in result #${i};` +
-          ` '${result.timestamp}' does not match ${timestampFormat}`)
+          ` '${result.timestamp}' does not match ${timestampFormat}`),
         )
       })
       done()
@@ -171,7 +174,7 @@ describe('order-book', function () {
         assert(
           moment(result.timestamp, timestampFormat, true).isValid(),
           (`Unexpected timestamp format in ask result #${i};` +
-          ` '${result.timestamp}' does not match ${timestampFormat}`)
+          ` '${result.timestamp}' does not match ${timestampFormat}`),
         )
       })
       assert(json.bid, 'Does not contain a \'bid\' field')
@@ -181,7 +184,7 @@ describe('order-book', function () {
         assert(
           moment(result.timestamp, timestampFormat, true).isValid(),
           (`Unexpected timestamp format in bid result #${i};` +
-          ` "${result.timestamp}" does not match ${timestampFormat}`)
+          ` "${result.timestamp}" does not match ${timestampFormat}`),
         )
       })
       done()

endpoints/bus/graphql_schema.js

@@ -33,6 +33,6 @@ export default {
     busses: { type: GraphQLString },
   },
   resolve: (_, args) => {
-    return getBusRoutes(args).then((data) => data.results, (error) => error)
+    return getBusRoutes(args).then(data => data.results, error => error)
   },
 }

endpoints/calendar/index.js

@@ -1,11 +1,13 @@
+/* eslint-disable prefer-promise-reject-errors */
+/* eslint-disable import/first */
 import app from '../../server'
 import fridagar from 'fridagar'
 import makeDebug from 'debug'
 import { range, isString } from 'lodash'
 
 const debug = makeDebug('endpoint:calendar')
 
-const canBeInt = intLike => {
+const canBeInt = (intLike) => {
   const num = Number.parseInt(intLike, 10)
   return !Number.isNaN(num)
 }
@@ -20,7 +22,9 @@ export const normalizeParams = (year, month, day) => {
 }
 
 const lookupHolidays = (yearStr, monthStr, dayStr) => new Promise((resolve, reject) => {
-  const { year, month, day, error } = normalizeParams(yearStr, monthStr, dayStr)
+  const {
+    year, month, day, error,
+  } = normalizeParams(yearStr, monthStr, dayStr)
 
   // Reject promise with relevant error when in error states
   if (error) reject({ error })
@@ -68,24 +72,24 @@ app.get('/calendar/:year', (req, res) => {
   const { year } = req.params
 
   lookupHolidays(year)
-    .then((holidays) => res.json({ results: holidays }))
-    .catch((error) => res.status(400).json(error))
+    .then(holidays => res.json({ results: holidays }))
+    .catch(error => res.status(400).json(error))
 })
 
 app.get('/calendar/:year/:month', (req, res) => {
   const { year, month } = req.params
 
   lookupHolidays(year, month)
-    .then((holidays) => res.json({ results: holidays }))
-    .catch((error) => res.status(400).json(error))
+    .then(holidays => res.json({ results: holidays }))
+    .catch(error => res.status(400).json(error))
 })
 
 app.get('/calendar/:year/:month/:day', (req, res) => {
   const { year, month, day } = req.params
 
   lookupHolidays(year, month, day)
-    .then((holiday) => res.json({ results: holiday }))
-    .catch((error) => res.status(400).json(error))
+    .then(holiday => res.json({ results: holiday }))
+    .catch(error => res.status(400).json(error))
 })
 
 export default lookupHolidays

endpoints/car/graphql_schema.js

@@ -66,5 +66,5 @@ export default {
   },
   resolve: (_, { carPlate }) => lookupCar(carPlate)
     .then(data => data)
-    .catch(error => { throw new Error(error) }),
+    .catch((error) => { throw new Error(error) }),
 }

endpoints/car/index.js

@@ -1,3 +1,4 @@
+/* eslint-disable prefer-promise-reject-errors */
 import request from 'request'
 import $ from 'cheerio'
 import h from 'apis-helpers'

endpoints/car/tests/integration_test.js

@@ -1,3 +1,4 @@
+/* eslint-disable import/extensions */
 import request from 'request'
 import helpers from '../../../lib/test_helpers.js'
 

endpoints/carparks/index.js

@@ -1,3 +1,5 @@
+/* eslint-disable no-restricted-globals */
+/* eslint-disable no-plusplus */
 import request from 'request'
 import $ from 'cheerio'
 import h from 'apis-helpers'

endpoints/carparks/tests/integration_test.js

@@ -1,3 +1,4 @@
+/* eslint-disable import/extensions */
 import request from 'request'
 import helpers from '../../../lib/test_helpers.js'
 

endpoints/company/tests/integration_test.js

@@ -1,3 +1,4 @@
+/* eslint-disable import/extensions */
 import request from 'request'
 import helpers from '../../../lib/test_helpers.js'
 

endpoints/concerts/index.js

@@ -13,15 +13,15 @@ app.get('/concerts', (req, res) => {
       })
     }
     const events = JSON.parse(body)
-    const filtered = _.map(events, (event) => (
+    const filtered = _.map(events, event => (
       _.pick(
         event,
         'eventDateName',
         'name',
         'dateOfShow',
         'userGroupName',
         'eventHallName',
-        'imageSource'
+        'imageSource',
       )
     ))
     return res.json({ results: filtered })

endpoints/concerts/tests/integration_test.js

@@ -1,3 +1,4 @@
+/* eslint-disable import/extensions */
 import request from 'request'
 import helpers from '../../../lib/test_helpers.js'
 

endpoints/currency/borgun.js

@@ -1,6 +1,9 @@
+/* eslint-disable no-plusplus */
+/* eslint-disable prefer-destructuring */
 import request from 'request'
 import xml2js from 'xml2js'
 import app from '../../server'
+
 const parseString = xml2js.parseString
 
 app.get('/currency/borgun', (req, res) => {
@@ -31,6 +34,6 @@ app.get('/currency/borgun', (req, res) => {
         }
         return res.json({ results: currencies })
       })
-    }
+    },
   )
 })

endpoints/currency/lb.js

@@ -1,6 +1,9 @@
+/* eslint-disable no-plusplus */
+/* eslint-disable prefer-destructuring */
 import request from 'request'
 import xml2js from 'xml2js'
 import app from '../../server'
+
 const parseString = xml2js.parseString
 
 app.get('/currency/lb/:type?', (req, res) => {
@@ -30,6 +33,5 @@ app.get('/currency/lb/:type?', (req, res) => {
       }
       return res.json({ results: currencies })
     })
-  }
-  )
+  })
 })

endpoints/currency/m5.js

@@ -1,3 +1,4 @@
+/* eslint-disable import/first */
 import request from 'request'
 import h from 'apis-helpers'
 import app from '../../server'

endpoints/currency/tests/integration_test.js

@@ -1,8 +1,9 @@
+/* eslint-disable import/extensions */
 import request from 'request'
 import helpers from '../../../lib/test_helpers.js'
 
 describe('currency', () => {
-    // The only thing that changes is the form attribute, so why not just re-use the object
+  // The only thing that changes is the form attribute, so why not just re-use the object
   const fieldsToCheckFor = ['shortName', 'longName', 'value', 'askValue', 'bidValue', 'changeCur', 'changePer']
 
   describe('searching using provider "m5"', () => {

endpoints/cyclecounter/index.js

@@ -1,6 +1,8 @@
+/* eslint-disable prefer-destructuring */
 import request from 'request'
 import xml2js from 'xml2js'
 import app from '../../server'
+
 const parseString = xml2js.parseString
 
 app.get('/cyclecounter', (req, res) => {
@@ -22,6 +24,5 @@ app.get('/cyclecounter', (req, res) => {
 
       return res.json({ results: cyclecounter })
     })
-  }
-  )
+  })
 })

endpoints/cyclecounter/tests/integration_test.js

@@ -1,8 +1,9 @@
+/* eslint-disable import/extensions */
 import request from 'request'
 import helpers from '../../../lib/test_helpers.js'
 
 describe('cyclecounter', () => {
-    // The only thing that changes is the form attribute, so why not just re-use the object
+  // The only thing that changes is the form attribute, so why not just re-use the object
   const fieldsToCheckFor = ['DayCount', 'YearCount', 'Time', 'Date']
 
   it('should return an array of objects containing correct fields', (done) => {

endpoints/declension/index.js

@@ -1,3 +1,6 @@
+/* eslint-disable prefer-destructuring */
+/* eslint-disable no-mixed-operators */
+/* eslint-disable import/first */
 import app from '../../server'
 import request from 'request'
 import helper from 'apis-helpers'

endpoints/declension/tests/integration_test.js

@@ -1,3 +1,4 @@
+/* eslint-disable import/extensions */
 import request from 'request'
 import helpers from '../../../lib/test_helpers.js'