Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for preNavigationHooks in Playwright #427

Closed
viewv opened this issue Aug 13, 2024 · 8 comments · Fixed by #631
Closed

Add support for preNavigationHooks in Playwright #427

viewv opened this issue Aug 13, 2024 · 8 comments · Fixed by #631
Labels
enhancement New feature or request. hacktoberfest t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@viewv
Copy link

viewv commented Aug 13, 2024

As the title, I want to know does the crawlee-python support the preNavigationHooks function?

@janbuchar janbuchar added enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team. labels Aug 13, 2024
@janbuchar
Copy link
Collaborator

Hello and thanks for your interest in Crawlee for Python! Pre-navigation hooks are not currently supported. Before we implement this, would putting the hook code into the request handler help? Or do you need to do something before the page is loaded?

@viewv
Copy link
Author

viewv commented Aug 13, 2024

Hello and thanks for your interest in Crawlee for Python! Pre-navigation hooks are not currently supported. Before we implement this, would putting the hook code into the request handler help? Or do you need to do something before the page is loaded?

OK, thank you, I want to change some browser properties before the page loaded, so I think it will be really helpful to support the preNavigationHooks.

@Tallone
Copy link

Tallone commented Aug 23, 2024

I want to do something before the page loads, such as aborting when loading some images or CSS, Is there any trick available to achieve this as of now?

@vdusek
Copy link
Collaborator

vdusek commented Sep 25, 2024

Implementation from Crawlee JS:

@vdusek vdusek changed the title Does the crawlee-python supports preNavigationHooks? Add support for preNavigationHooks in Playwright Sep 25, 2024
@Yashwanth-Chandrakumar
Copy link

@vdusek /assign

@janbuchar
Copy link
Collaborator

@vdusek /assign

We don't assign issues for hacktoberfest. If you want to contribute, open a PR whenever you're ready. First mergeable one gets merged.

@Yashwanth-Chandrakumar
Copy link

Yashwanth-Chandrakumar commented Oct 18, 2024

@janbuchar Thanks Mate

@Yashwanth-Chandrakumar
Copy link

@janbuchar i have created a PR to solve the issue please view it #602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. hacktoberfest t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants