Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests - finalization #66

Open
metalwarrior665 opened this issue Jun 4, 2024 · 0 comments
Open

Unit tests - finalization #66

metalwarrior665 opened this issue Jun 4, 2024 · 0 comments
Labels
priority: to be resolved Significant bug or high demand feature. Do it this or next sprint. source: internal Reported or found out by us tests Adding or fixing unit or end2end tests

Comments

@metalwarrior665
Copy link
Contributor

Implement unit tests (or update current ones) that will

  1. Test all parsers. This might require doing some refactor, ideally the code is as clean that we only parse data coming from the website once (e.g. part of HTML or JSON -> part of dataset item). These should test against exact values as coming from the website, not just schema.
  2. Test internal transformations - e.g. parsing from URL, categorizing inputs/URLs

Our OKR is to cover 80% use-cases but let's try to get closer to 100% :)

More details on how we want to structure tests: https://www.notion.so/apify/Tests-revamp-2024-Q1-2-b411bbfbf7e74af6a5f24fb36fe68332

@metalwarrior665 metalwarrior665 added priority: to be resolved Significant bug or high demand feature. Do it this or next sprint. source: internal Reported or found out by us tests Adding or fixing unit or end2end tests labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: to be resolved Significant bug or high demand feature. Do it this or next sprint. source: internal Reported or found out by us tests Adding or fixing unit or end2end tests
Projects
None yet
Development

No branches or pull requests

1 participant