Merge pull request #208 from apiaryio/kylef/oas3-invalid-schemes

Handle invalid security scheme components

Author: pksunkara

Diff for: packages/fury-adapter-oas3-parser/CHANGELOG.md

@@ -7,6 +7,9 @@
 - Fixes a bug where parsing an OpenAPI 3.1.0 or higher document will result in
   an parse result containing only a warning and missing the API Category.
 
+- Fixes the parser from throwing an error while handling invalid or unsupported
+  security scheme components.
+
 ## 0.7.2 (2019-04-01)
 
 ### Bug Fixes

Diff for: packages/fury-adapter-oas3-parser/lib/parser/oas/parseComponentsObject.js

@@ -150,9 +150,11 @@ function parseComponentsObject(context, element) {
       const array = new namespace.elements.Array([]);
 
       object.forEach((value, key) => {
-        // eslint-disable-next-line no-param-reassign
-        value.meta.id = key.clone();
-        array.push(value);
+        if (value) {
+          // eslint-disable-next-line no-param-reassign
+          value.meta.id = key.clone();
+          array.push(value);
+        }
       });
 
       return array;

Diff for: packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseComponentsObject-test.js

@@ -322,6 +322,24 @@ describe('Components Object', () => {
       expect(securitySchemes.get(0)).to.be.instanceof(namespace.elements.AuthScheme);
       expect(securitySchemes.get(0).meta.id.toValue()).to.equal('token');
     });
+
+    it('handles invalid security scheme', () => {
+      const components = new namespace.elements.Object({
+        securitySchemes: {
+          Basic: null,
+        },
+      });
+
+      const parseResult = parse(context, components);
+      expect(parseResult.length).to.equal(2);
+
+      const parsedComponents = parseResult.get(0);
+      expect(parsedComponents).to.be.instanceof(namespace.elements.Object);
+
+      const schemes = parsedComponents.get('securitySchemes');
+      expect(schemes).to.be.instanceof(namespace.elements.Array);
+      expect(schemes.isEmpty).to.be.true;
+    });
   });
 
   describe('#examples', () => {