Should retries be automatic?

[mashirooooo]

when i use mysql backend, i found something is error;

 Monitor::new()
        .register({
            WorkerBuilder::new("auto_build_task")
                .enable_tracing()
                .backend(auto_build_storage.clone())
                .build_fn(auto_build_task)
        })
        .register({
            WorkerBuilder::new("check_auto_build_task")
                .enable_tracing()
                .backend(auto_build_check_storage.clone())
                .build_fn(check_auto_build_task)
        })
        .run()
        .await?;

async fn check_auto_build_task(req: CheckHandleAutoBuildTaskResult) -> Result<(), Error> {
    let result = handle_build_call_back(&req.data.auto_build_id, false).await;
    match result {
        Ok(_) => {
            log_serialize!("success", req);
            Ok(())
        }
        Err(e) => {
            log_serialize!("fail: {}", e);
            let err: BoxDynError = e.into();
            Err(err.into())
        }
    }
}

when i return Ok(()) or Err,they will retry 5 times, i dont konwn why ?

[mashirooooo]

apalis-sql = { version = "0.7",features = ["mysql"]}
apalis = { version = "0.7", features = ["limit", "timeout"]}

cargo dependencies

[geofmureithi]

If you can also include the output of tracing, that would be great.

If you return OK, it should run only once as seen in this test.

In the case of error, it will retry 5 times by default which is set here.

If you wanna customize the number of retries, you should use push_request instead of push, then call ctx.set_max_retries(0)

[mashirooooo]

If you can also include the output of tracing, that would be great.

If you return OK, it should run only once as seen in this test.

In the case of error, it will retry 5 times by default which is set here.

If you wanna customize the number of retries, you should use push_request instead of push, then call ctx.set_max_retries(0)

It seems that the function is supposed to return a type like &'static str or String, rather than a Result type. Shouldn't we avoid using anyhow::Result<(), Error> in this case?

[geofmureithi]

No, you can use anything that implements IntoResponse and Result is one of them as shown here.

[geofmureithi]

I will be moving this into discussions because I dont believe there is a bug as reported.

[mashirooooo]

but when i return Ok,it also run 5 times, the mysql record last_error is {"Ok": null }