-
Notifications
You must be signed in to change notification settings - Fork 15.6k
Closed
Labels
frontend:refactor:antd5good first issueGood first issues for new contributorsGood first issues for new contributorspreset:bountyIssues that have been selected by Preset and have a bounty attached.Issues that have been selected by Preset and have a bounty attached.preset:bounty:choreChores that have been selected by Preset and have a bounty attached.Chores that have been selected by Preset and have a bounty attached.
Description
Please refer to SIP-139 #29268.
The src/components/IconButton
component should be removed and a standard Card
component from Ant Design version 5 should be used instead.
The component is currently being used in the Database modal.
The codebase is moving to Ant Design 5. Similar work has been completed here.
When upgrading the component to Ant Design 5, please ensure to include:
- Do not use unnecessary custom styles. We want to go as vanilla Ant Design as possible.
- Proper RTL test coverage.
- A Storybook file.
- Include all relevant component options in the Storybook.
When opening a PR:
- Name your PR refactor({Component}): Refactor IconButton to use Ant Design 5 Card
- Add screenshots of BEFORE/AFTER in your PR.
- Make sure you or a committer has labeled your PR with frontend:refactor:antd5.
Metadata
Metadata
Assignees
Labels
frontend:refactor:antd5good first issueGood first issues for new contributorsGood first issues for new contributorspreset:bountyIssues that have been selected by Preset and have a bounty attached.Issues that have been selected by Preset and have a bounty attached.preset:bounty:choreChores that have been selected by Preset and have a bounty attached.Chores that have been selected by Preset and have a bounty attached.