diff --git a/common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java b/common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java index dd7c2061ec95b..51359de11d4df 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java +++ b/common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java @@ -29,8 +29,6 @@ import com.google.common.io.ByteStreams; import io.netty.channel.DefaultFileRegion; import io.netty.handler.stream.ChunkedStream; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.util.JavaUtils; import org.apache.spark.network.util.LimitedInputStream; @@ -152,10 +150,7 @@ public Object convertToNettyForSsl() throws IOException { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("file", file) - .append("offset", offset) - .append("length", length) - .toString(); + return "FileSegmentManagedBuffer[file=" + file + ",offset=" + offset + + ",length=" + length + "]"; } } diff --git a/common/network-common/src/main/java/org/apache/spark/network/buffer/NettyManagedBuffer.java b/common/network-common/src/main/java/org/apache/spark/network/buffer/NettyManagedBuffer.java index a40cfc8bc04b1..e7b8bafa92f4b 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/buffer/NettyManagedBuffer.java +++ b/common/network-common/src/main/java/org/apache/spark/network/buffer/NettyManagedBuffer.java @@ -23,8 +23,6 @@ import io.netty.buffer.ByteBuf; import io.netty.buffer.ByteBufInputStream; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; /** * A {@link ManagedBuffer} backed by a Netty {@link ByteBuf}. @@ -75,8 +73,6 @@ public Object convertToNettyForSsl() throws IOException { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("buf", buf) - .toString(); + return "NettyManagedBuffer[buf=" + buf + "]"; } } diff --git a/common/network-common/src/main/java/org/apache/spark/network/buffer/NioManagedBuffer.java b/common/network-common/src/main/java/org/apache/spark/network/buffer/NioManagedBuffer.java index 6eb8d4e2c731c..d97f853c58f1f 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/buffer/NioManagedBuffer.java +++ b/common/network-common/src/main/java/org/apache/spark/network/buffer/NioManagedBuffer.java @@ -23,8 +23,6 @@ import io.netty.buffer.ByteBufInputStream; import io.netty.buffer.Unpooled; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; /** * A {@link ManagedBuffer} backed by {@link ByteBuffer}. @@ -73,9 +71,7 @@ public Object convertToNettyForSsl() throws IOException { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("buf", buf) - .toString(); + return "NioManagedBuffer[buf=" + buf + "]"; } } diff --git a/common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java b/common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java index a9df47645d36f..08449a2284404 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java +++ b/common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java @@ -33,8 +33,6 @@ import io.netty.channel.Channel; import io.netty.util.concurrent.Future; import io.netty.util.concurrent.GenericFutureListener; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.internal.SparkLogger; import org.apache.spark.internal.SparkLoggerFactory; @@ -338,11 +336,8 @@ public void close() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("remoteAddress", channel.remoteAddress()) - .append("clientId", clientId) - .append("isActive", isActive()) - .toString(); + return "TransportClient[remoteAddress=" + channel.remoteAddress() + "clientId=" + clientId + + ",isActive=" + isActive() + "]"; } private static long requestId() { diff --git a/common/network-common/src/main/java/org/apache/spark/network/protocol/ChunkFetchFailure.java b/common/network-common/src/main/java/org/apache/spark/network/protocol/ChunkFetchFailure.java index cbad4c61b9b4a..736d8e6f5eea2 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/protocol/ChunkFetchFailure.java +++ b/common/network-common/src/main/java/org/apache/spark/network/protocol/ChunkFetchFailure.java @@ -20,8 +20,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; /** * Response to {@link ChunkFetchRequest} when there is an error fetching the chunk. @@ -70,9 +68,6 @@ public boolean equals(Object other) { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("streamChunkId", streamChunkId) - .append("errorString", errorString) - .toString(); + return "ChunkFetchFailure[streamChunkId=" + streamChunkId + ",errorString=" + errorString + "]"; } } diff --git a/common/network-common/src/main/java/org/apache/spark/network/protocol/ChunkFetchRequest.java b/common/network-common/src/main/java/org/apache/spark/network/protocol/ChunkFetchRequest.java index 2865388b3297c..cc042fdf76b77 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/protocol/ChunkFetchRequest.java +++ b/common/network-common/src/main/java/org/apache/spark/network/protocol/ChunkFetchRequest.java @@ -18,8 +18,6 @@ package org.apache.spark.network.protocol; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; /** * Request to fetch a sequence of a single chunk of a stream. This will correspond to a single @@ -64,8 +62,6 @@ public boolean equals(Object other) { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("streamChunkId", streamChunkId) - .toString(); + return "ChunkFetchRequest[streamChunkId=" + streamChunkId + "]"; } } diff --git a/common/network-common/src/main/java/org/apache/spark/network/protocol/ChunkFetchSuccess.java b/common/network-common/src/main/java/org/apache/spark/network/protocol/ChunkFetchSuccess.java index 9480fdd0b862b..948190e7a2d53 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/protocol/ChunkFetchSuccess.java +++ b/common/network-common/src/main/java/org/apache/spark/network/protocol/ChunkFetchSuccess.java @@ -20,8 +20,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.buffer.ManagedBuffer; import org.apache.spark.network.buffer.NettyManagedBuffer; @@ -83,9 +81,6 @@ public boolean equals(Object other) { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("streamChunkId", streamChunkId) - .append("body", body()) - .toString(); + return "ChunkFetchSuccess[streamChunkId=" + streamChunkId + ",body=" + body() + "]"; } } diff --git a/common/network-common/src/main/java/org/apache/spark/network/protocol/MergedBlockMetaRequest.java b/common/network-common/src/main/java/org/apache/spark/network/protocol/MergedBlockMetaRequest.java index 3723730ebc06c..91babef9b6d58 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/protocol/MergedBlockMetaRequest.java +++ b/common/network-common/src/main/java/org/apache/spark/network/protocol/MergedBlockMetaRequest.java @@ -19,8 +19,6 @@ import com.google.common.base.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; /** * Request to find the meta information for the specified merged block. The meta information @@ -94,12 +92,7 @@ public boolean equals(Object other) { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("requestId", requestId) - .append("appId", appId) - .append("shuffleId", shuffleId) - .append("shuffleMergeId", shuffleMergeId) - .append("reduceId", reduceId) - .toString(); + return "MergedBlockMetaRequest[requestId=" + requestId + ",appId=" + appId + ",shuffleId=" + + shuffleId + ",shuffleMergeId=" + shuffleMergeId + ",reduceId=" + reduceId + "]"; } } diff --git a/common/network-common/src/main/java/org/apache/spark/network/protocol/MergedBlockMetaSuccess.java b/common/network-common/src/main/java/org/apache/spark/network/protocol/MergedBlockMetaSuccess.java index d2edaf4532e11..c8657b2becd7a 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/protocol/MergedBlockMetaSuccess.java +++ b/common/network-common/src/main/java/org/apache/spark/network/protocol/MergedBlockMetaSuccess.java @@ -19,8 +19,6 @@ import com.google.common.base.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.buffer.ManagedBuffer; import org.apache.spark.network.buffer.NettyManagedBuffer; @@ -56,8 +54,7 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("requestId", requestId).append("numChunks", numChunks).toString(); + return "MergedBlockMetaSuccess[requestId=" + requestId + ",numChunks=" + numChunks + "]"; } @Override diff --git a/common/network-common/src/main/java/org/apache/spark/network/protocol/OneWayMessage.java b/common/network-common/src/main/java/org/apache/spark/network/protocol/OneWayMessage.java index 91c818f3612a9..de1f91bc8d318 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/protocol/OneWayMessage.java +++ b/common/network-common/src/main/java/org/apache/spark/network/protocol/OneWayMessage.java @@ -20,8 +20,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.buffer.ManagedBuffer; import org.apache.spark.network.buffer.NettyManagedBuffer; @@ -74,8 +72,6 @@ public boolean equals(Object other) { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("body", body()) - .toString(); + return "OneWayMessage[body=" + body() + "]"; } } diff --git a/common/network-common/src/main/java/org/apache/spark/network/protocol/RpcFailure.java b/common/network-common/src/main/java/org/apache/spark/network/protocol/RpcFailure.java index 02a45d68c650e..f48264a494f0e 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/protocol/RpcFailure.java +++ b/common/network-common/src/main/java/org/apache/spark/network/protocol/RpcFailure.java @@ -20,8 +20,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; /** Response to {@link RpcRequest} for a failed RPC. */ public final class RpcFailure extends AbstractMessage implements ResponseMessage { @@ -68,9 +66,6 @@ public boolean equals(Object other) { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("requestId", requestId) - .append("errorString", errorString) - .toString(); + return "RpcFailure[requestId=" + requestId + ",errorString=" + errorString + "]"; } } diff --git a/common/network-common/src/main/java/org/apache/spark/network/protocol/RpcRequest.java b/common/network-common/src/main/java/org/apache/spark/network/protocol/RpcRequest.java index a7dbe1283b314..2619b176e331e 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/protocol/RpcRequest.java +++ b/common/network-common/src/main/java/org/apache/spark/network/protocol/RpcRequest.java @@ -20,8 +20,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.buffer.ManagedBuffer; import org.apache.spark.network.buffer.NettyManagedBuffer; @@ -80,9 +78,6 @@ public boolean equals(Object other) { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("requestId", requestId) - .append("body", body()) - .toString(); + return "RpcRequest[requestId=" + requestId + ",body=" + body() + "]"; } } diff --git a/common/network-common/src/main/java/org/apache/spark/network/protocol/RpcResponse.java b/common/network-common/src/main/java/org/apache/spark/network/protocol/RpcResponse.java index 85709e36f83ee..a9805bcf686b4 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/protocol/RpcResponse.java +++ b/common/network-common/src/main/java/org/apache/spark/network/protocol/RpcResponse.java @@ -20,8 +20,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.buffer.ManagedBuffer; import org.apache.spark.network.buffer.NettyManagedBuffer; @@ -80,9 +78,6 @@ public boolean equals(Object other) { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("requestId", requestId) - .append("body", body()) - .toString(); + return "RpcResponse[requestId=" + requestId + ",body=" + body() + "]"; } } diff --git a/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamChunkId.java b/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamChunkId.java index c3b715009dffe..61aae3e36eceb 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamChunkId.java +++ b/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamChunkId.java @@ -20,8 +20,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; /** * Encapsulates a request for a particular chunk of a stream. @@ -61,9 +59,6 @@ public boolean equals(Object other) { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("streamId", streamId) - .append("chunkIndex", chunkIndex) - .toString(); + return "StreamChunkId[streamId=" + streamId + ",chunkIndex=" + chunkIndex + "]"; } } diff --git a/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamFailure.java b/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamFailure.java index 9a7bf2f65af3a..50cc25a4919a5 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamFailure.java +++ b/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamFailure.java @@ -20,8 +20,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; /** * Message indicating an error when transferring a stream. @@ -70,10 +68,7 @@ public boolean equals(Object other) { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("streamId", streamId) - .append("error", error) - .toString(); + return "StreamFailure[streamId=" + streamId + ",error=" + error + "]"; } } diff --git a/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamRequest.java b/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamRequest.java index 5906b4d380d6e..45ca2578b01a4 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamRequest.java +++ b/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamRequest.java @@ -20,8 +20,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; /** * Request to stream data from the remote end. @@ -69,9 +67,7 @@ public boolean equals(Object other) { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("streamId", streamId) - .toString(); + return "StreamRequest[streamId=" + streamId + "]"; } } diff --git a/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamResponse.java b/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamResponse.java index 0c0aa5c9a635b..d7c304e5c5b34 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamResponse.java +++ b/common/network-common/src/main/java/org/apache/spark/network/protocol/StreamResponse.java @@ -20,8 +20,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.buffer.ManagedBuffer; @@ -83,11 +81,8 @@ public boolean equals(Object other) { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("streamId", streamId) - .append("byteCount", byteCount) - .append("body", body()) - .toString(); + return "StreamResponse[streamId=" + streamId + ",byteCount=" + byteCount + + ",body=" + body() + "]"; } } diff --git a/common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java b/common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java index 4722f39dfa9db..09baaf60c3f92 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java +++ b/common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java @@ -21,8 +21,6 @@ import java.nio.ByteBuffer; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.buffer.ManagedBuffer; import org.apache.spark.network.buffer.NettyManagedBuffer; @@ -99,9 +97,6 @@ public boolean equals(Object other) { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("requestId", requestId) - .append("body", body()) - .toString(); + return "UploadStream[requestId=" + requestId + ",body=" + body() + "]"; } } diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java index f5025fdeaf8ec..1950901fdcfaf 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java @@ -26,8 +26,6 @@ import java.util.concurrent.Executors; import java.util.stream.Collectors; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import com.fasterxml.jackson.annotation.JsonCreator; import com.fasterxml.jackson.annotation.JsonProperty; import com.fasterxml.jackson.databind.ObjectMapper; @@ -451,10 +449,7 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("appId", appId) - .append("execId", execId) - .toString(); + return "ExternalShuffleBlockResolver[appId=" + appId + ",execId=" + execId + "]"; } } diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/AbstractFetchShuffleBlocks.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/AbstractFetchShuffleBlocks.java index 0fca27cf26dfa..7c15abfd83d1e 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/AbstractFetchShuffleBlocks.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/AbstractFetchShuffleBlocks.java @@ -43,12 +43,14 @@ protected AbstractFetchShuffleBlocks( this.shuffleId = shuffleId; } + // checkstyle.off: RegexpSinglelineJava public ToStringBuilder toStringHelper() { return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) .append("appId", appId) .append("execId", execId) .append("shuffleId", shuffleId); } + // checkstyle.on: RegexpSinglelineJava /** * Returns number of blocks in the request. diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/BlockPushReturnCode.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/BlockPushReturnCode.java index 05347c671e002..891ca7902f864 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/BlockPushReturnCode.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/BlockPushReturnCode.java @@ -21,8 +21,6 @@ import com.google.common.base.Preconditions; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.protocol.Encoders; import org.apache.spark.network.server.BlockPushNonFatalFailure; @@ -60,10 +58,8 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("returnCode", returnCode) - .append("failureBlockId", failureBlockId) - .toString(); + return "BlockPushReturnCode[returnCode=" + returnCode + + ",failureBlockId=" + failureBlockId + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/BlocksRemoved.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/BlocksRemoved.java index 2a050ce40b84b..9942d68297595 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/BlocksRemoved.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/BlocksRemoved.java @@ -20,8 +20,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; // Needed by ScalaDoc. See SPARK-7726 import static org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type; @@ -44,9 +42,7 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("numRemovedBlocks", numRemovedBlocks) - .toString(); + return "BlocksRemoved[numRemovedBlocks=" + numRemovedBlocks + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/CorruptionCause.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/CorruptionCause.java index 5690eee53bd13..d9b9d4d8f36c2 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/CorruptionCause.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/CorruptionCause.java @@ -18,8 +18,6 @@ package org.apache.spark.network.shuffle.protocol; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.shuffle.checksum.Cause; @@ -38,9 +36,7 @@ protected Type type() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("cause", cause) - .toString(); + return "CorruptionCause[cause=" + cause + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/DiagnoseCorruption.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/DiagnoseCorruption.java index 620b5ad71cd75..e509f45a9f0e3 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/DiagnoseCorruption.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/DiagnoseCorruption.java @@ -18,8 +18,6 @@ package org.apache.spark.network.shuffle.protocol; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.protocol.Encoders; /** Request to get the cause of a corrupted block. Returns {@link CorruptionCause} */ @@ -56,15 +54,9 @@ protected Type type() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("appId", appId) - .append("execId", execId) - .append("shuffleId", shuffleId) - .append("mapId", mapId) - .append("reduceId", reduceId) - .append("checksum", checksum) - .append("algorithm", algorithm) - .toString(); + return "DiagnoseCorruption[appId=" + appId + ",execId=" + execId + ",shuffleId=" + shuffleId + + ",mapId=" + mapId + ",reduceId=" + reduceId + ",checksum=" + checksum + + ",algorithm=" + algorithm + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/ExecutorShuffleInfo.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/ExecutorShuffleInfo.java index 8a3ccdef2920b..c53ab911c30da 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/ExecutorShuffleInfo.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/ExecutorShuffleInfo.java @@ -23,8 +23,6 @@ import com.fasterxml.jackson.annotation.JsonCreator; import com.fasterxml.jackson.annotation.JsonProperty; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.protocol.Encodable; import org.apache.spark.network.protocol.Encoders; @@ -60,11 +58,8 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("localDirs", Arrays.toString(localDirs)) - .append("subDirsPerLocalDir", subDirsPerLocalDir) - .append("shuffleManager", shuffleManager) - .toString(); + return "ExecutorShuffleInfo[localDirs=" + Arrays.toString(localDirs) + + ",subDirsPerLocalDir=" + subDirsPerLocalDir + ",shuffleManager=" + shuffleManager + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FetchShuffleBlockChunks.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FetchShuffleBlockChunks.java index cf4cbcf1ed08e..a6e1ce374b07f 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FetchShuffleBlockChunks.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FetchShuffleBlockChunks.java @@ -60,11 +60,10 @@ public FetchShuffleBlockChunks( @Override public String toString() { - return toStringHelper() - .append("shuffleMergeId", shuffleMergeId) - .append("reduceIds", Arrays.toString(reduceIds)) - .append("chunkIds", Arrays.deepToString(chunkIds)) - .toString(); + return "FetchShuffleBlockChunks[appId=" + appId + ",execId=" + execId + + ",shuffleId=" + shuffleId + ",shuffleMergeId=" + shuffleMergeId + + ",reduceIds=" + Arrays.toString(reduceIds) + + ",chunkIds=" + Arrays.deepToString(chunkIds) + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FetchShuffleBlocks.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FetchShuffleBlocks.java index 68550a2fba86e..686207767ca1e 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FetchShuffleBlocks.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FetchShuffleBlocks.java @@ -62,11 +62,9 @@ public FetchShuffleBlocks( @Override public String toString() { - return toStringHelper() - .append("mapIds", Arrays.toString(mapIds)) - .append("reduceIds", Arrays.deepToString(reduceIds)) - .append("batchFetchEnabled", batchFetchEnabled) - .toString(); + return "FetchShuffleBlocks[appId=" + appId + ",execId=" + execId + ",shuffleId=" + shuffleId + + ",mapIds=" + Arrays.toString(mapIds) + ",reduceIds=" + Arrays.deepToString(reduceIds) + + ",batchFetchEnabled=" + batchFetchEnabled + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FinalizeShuffleMerge.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FinalizeShuffleMerge.java index cd5e005348f42..ed757c1b2d4a2 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FinalizeShuffleMerge.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FinalizeShuffleMerge.java @@ -19,8 +19,6 @@ import com.google.common.base.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.protocol.Encoders; @@ -59,12 +57,8 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("appId", appId) - .append("attemptId", appAttemptId) - .append("shuffleId", shuffleId) - .append("shuffleMergeId", shuffleMergeId) - .toString(); + return "FinalizeShuffleMerge[appId=" + appId + ",attemptId=" + appAttemptId + + ",shuffleId=" + shuffleId + ",shuffleMergeId=" + shuffleMergeId + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/GetLocalDirsForExecutors.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/GetLocalDirsForExecutors.java index f118f0604d9e9..8bd106c94c283 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/GetLocalDirsForExecutors.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/GetLocalDirsForExecutors.java @@ -21,8 +21,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.protocol.Encoders; @@ -49,10 +47,7 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("appId", appId) - .append("execIds", Arrays.toString(execIds)) - .toString(); + return "GetLocalDirsForExecutors[appId=" + appId + ",execIds=" + Arrays.toString(execIds) + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/LocalDirsForExecutors.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/LocalDirsForExecutors.java index b65f351d3cf3e..060b565d420fd 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/LocalDirsForExecutors.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/LocalDirsForExecutors.java @@ -20,8 +20,6 @@ import java.util.*; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.protocol.Encoders; @@ -64,11 +62,9 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("execIds", Arrays.toString(execIds)) - .append("numLocalDirsByExec", Arrays.toString(numLocalDirsByExec)) - .append("allLocalDirs", Arrays.toString(allLocalDirs)) - .toString(); + return "LocalDirsForExecutors[execIds=" + Arrays.toString(execIds) + + ",numLocalDirsByExec=" + Arrays.toString(numLocalDirsByExec) + + ",allLocalDirs=" + Arrays.toString(allLocalDirs) + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/MergeStatuses.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/MergeStatuses.java index 892c3a5e77958..4142a5c9af2d8 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/MergeStatuses.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/MergeStatuses.java @@ -21,8 +21,6 @@ import com.google.common.base.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.roaringbitmap.RoaringBitmap; import org.apache.spark.network.protocol.Encoders; @@ -86,11 +84,8 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("shuffleId", shuffleId) - .append("shuffleMergeId", shuffleMergeId) - .append("reduceId size", reduceIds.length) - .toString(); + return "MergeStatuses[shuffleId=" + shuffleId + ",shuffleMergeId=" + shuffleMergeId + + ",reduceId size=" + reduceIds.length + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/OpenBlocks.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/OpenBlocks.java index 49288eef5c5de..87b40eb1fc6ac 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/OpenBlocks.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/OpenBlocks.java @@ -21,8 +21,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.protocol.Encoders; @@ -51,11 +49,8 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("appId", appId) - .append("execId", execId) - .append("blockIds", Arrays.toString(blockIds)) - .toString(); + return "OpenBlocks[appId=" + appId + ",execId=" + execId + ",blockIds=" + + Arrays.toString(blockIds) + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/PushBlockStream.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/PushBlockStream.java index ceab54a1c0615..d2aafc104495a 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/PushBlockStream.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/PushBlockStream.java @@ -20,9 +20,6 @@ import com.google.common.base.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; - import org.apache.spark.network.protocol.Encoders; // Needed by ScalaDoc. See SPARK-7726 @@ -74,15 +71,9 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("appId", appId) - .append("attemptId", appAttemptId) - .append("shuffleId", shuffleId) - .append("shuffleMergeId", shuffleMergeId) - .append("mapIndex", mapIndex) - .append("reduceId", reduceId) - .append("index", index) - .toString(); + return "PushBlockStream[appId=" + appId + ",attemptId=" + appAttemptId + + ",shuffleId=" + shuffleId + ",shuffleMergeId=" + shuffleMergeId + ",mapIndex=" + mapIndex + + ",reduceId=" + reduceId + ",index=" + index + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/RegisterExecutor.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/RegisterExecutor.java index 9805af67b9f26..a5931126e4ff8 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/RegisterExecutor.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/RegisterExecutor.java @@ -20,8 +20,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.protocol.Encoders; @@ -56,11 +54,8 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("appId", appId) - .append("execId", execId) - .append("executorInfo", executorInfo) - .toString(); + return "RegisterExecutor[appId=" + appId + ", execId=" + execId + + ",executorInfo=" + executorInfo + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/RemoveBlocks.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/RemoveBlocks.java index 7032942331c3e..2743824b3d21c 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/RemoveBlocks.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/RemoveBlocks.java @@ -21,8 +21,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.protocol.Encoders; @@ -51,11 +49,8 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("appId", appId) - .append("execId", execId) - .append("blockIds", Arrays.toString(blockIds)) - .toString(); + return "RemoveBlocks[appId=" + appId + ",execId=" + execId + + ",blockIds=" + Arrays.toString(blockIds) + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/RemoveShuffleMerge.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/RemoveShuffleMerge.java index 8ce2e05e6097d..05ef6fe1fe6ca 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/RemoveShuffleMerge.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/RemoveShuffleMerge.java @@ -19,8 +19,6 @@ import com.google.common.base.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.protocol.Encoders; @@ -59,12 +57,8 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("appId", appId) - .append("attemptId", appAttemptId) - .append("shuffleId", shuffleId) - .append("shuffleMergeId", shuffleMergeId) - .toString(); + return "RemoveShuffleMerge[appId=" + appId + ",attemptId=" + appAttemptId + + ",shuffleId=" + shuffleId + ",shuffleMergeId=" + shuffleMergeId + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/StreamHandle.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/StreamHandle.java index aebd6f0d5a620..629e3c472e0a6 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/StreamHandle.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/StreamHandle.java @@ -20,8 +20,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; // Needed by ScalaDoc. See SPARK-7726 import static org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type; @@ -49,10 +47,7 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("streamId", streamId) - .append("numChunks", numChunks) - .toString(); + return "StreamHandle[streamId=" + streamId + ",numChunks=" + numChunks + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/UploadBlock.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/UploadBlock.java index fad187971e09a..9222134e6bb7f 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/UploadBlock.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/UploadBlock.java @@ -21,8 +21,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.protocol.Encoders; @@ -68,13 +66,8 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("appId", appId) - .append("execId", execId) - .append("blockId", blockId) - .append("metadata size", metadata.length) - .append("block size", blockData.length) - .toString(); + return "UploadBlock[appId=" + appId + ",execId=" + execId + ",blockId=" + blockId + + ",metadata size=" + metadata.length + ",block size=" + blockData.length + "]"; } @Override diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/UploadBlockStream.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/UploadBlockStream.java index 95d0b3835562d..45c4c5f98de74 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/UploadBlockStream.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/UploadBlockStream.java @@ -21,8 +21,6 @@ import java.util.Objects; import io.netty.buffer.ByteBuf; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.spark.network.protocol.Encoders; @@ -55,10 +53,7 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("blockId", blockId) - .append("metadata size", metadata.length) - .toString(); + return "UploadBlockStream[blockId=" + blockId + ",metadata size=" + metadata.length + "]"; } @Override diff --git a/common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java b/common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java index e0af3c5ae2468..c0f795b98e062 100644 --- a/common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java +++ b/common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java @@ -33,8 +33,6 @@ import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Preconditions; import com.google.common.collect.Lists; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.fs.FileSystem; import org.apache.hadoop.fs.Path; @@ -615,9 +613,7 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("appId", appId) - .toString(); + return "AppId[appId=" + appId + "]"; } } diff --git a/dev/checkstyle.xml b/dev/checkstyle.xml index 6a2afc08340a6..796069d830844 100644 --- a/dev/checkstyle.xml +++ b/dev/checkstyle.xml @@ -190,6 +190,10 @@ + + + + diff --git a/scalastyle-config.xml b/scalastyle-config.xml index da3399f2371fb..e0a780515d11a 100644 --- a/scalastyle-config.xml +++ b/scalastyle-config.xml @@ -299,6 +299,11 @@ This file is divided into 3 sections: Use org.apache.spark.util.Pair instead + + org\.apache\.commons\.lang3\.builder\.ToStringBuilder + Use String concatenation instead + + UriBuilder\.fromUri Use Utils.getUriBuilder instead. diff --git a/sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDeserializationSuite.java b/sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDeserializationSuite.java index a83041dc522c6..79a7d2b71cc43 100644 --- a/sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDeserializationSuite.java +++ b/sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDeserializationSuite.java @@ -24,8 +24,6 @@ import java.time.LocalDate; import java.util.*; -import org.apache.commons.lang3.builder.ToStringBuilder; -import org.apache.commons.lang3.builder.ToStringStyle; import org.junit.jupiter.api.*; import org.apache.spark.api.java.function.MapFunction; @@ -493,17 +491,10 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("shortField", shortField) - .append("intField", intField) - .append("longField", longField) - .append("floatField", floatField) - .append("doubleField", doubleField) - .append("stringField", stringField) - .append("booleanField", booleanField) - .append("timestampField", timestampField) - .append("nullIntField", nullIntField) - .toString(); + return "RecordSpark22000[shortField=" + shortField + ",intField=" + intField + + ",longField=" + longField + ",floatField=" + floatField + ",doubleField=" + doubleField + + ",stringField=" + stringField + ",booleanField=" + booleanField + + ",timestampField=" + timestampField + ",nullIntField=" + nullIntField + "]"; } } @@ -680,10 +671,8 @@ public int hashCode() { @Override public String toString() { - return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE) - .append("localDateField", localDateField) - .append("instantField", instantField) - .toString(); + return "LocalDateInstantRecord[localDateField=" + localDateField + + ",instantField=" + instantField + "]"; } }