Skip to content

Commit ec6122f

Browse files
committed
[SPARK-54100][BUILD] Remove ignore.symbol.file Javac option
### What changes were proposed in this pull request? This PR aims to remove `ignore.symbol.file` Javac option. ### Why are the changes needed? Since Apache Spark 4.0.0, we are building with `-release` which means `Javac` always uses `ct.sym`, a stripped-down version of the standard library (like rt.jar in older JDKs) containing only the necessary class stubs and signature data for the documented APIs of a specific Java release. In other words, `ignore.symbol.file` option is ignored now and we can remove it safely. - #45716 ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Pass the CIs. **BEFORE** ``` $ git grep ignore.symbol.file | wc -l 4 ``` **AFTER** ``` $ git grep ignore.symbol.file | wc -l 0 ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52802 from dongjoon-hyun/SPARK-54100. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
1 parent 7c5a9a3 commit ec6122f

File tree

4 files changed

+1
-22
lines changed

4 files changed

+1
-22
lines changed

common/sketch/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,6 @@
6060
<plugin>
6161
<groupId>net.alchim31.maven</groupId>
6262
<artifactId>scala-maven-plugin</artifactId>
63-
<configuration>
64-
<javacArgs combine.children="append">
65-
<!-- This option is needed to suppress warnings from sun.misc.Unsafe usage -->
66-
<javacArg>-XDignore.symbol.file</javacArg>
67-
</javacArgs>
68-
</configuration>
6963
</plugin>
7064
</plugins>
7165
</build>

common/unsafe/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -135,12 +135,6 @@
135135
<plugin>
136136
<groupId>net.alchim31.maven</groupId>
137137
<artifactId>scala-maven-plugin</artifactId>
138-
<configuration>
139-
<javacArgs combine.children="append">
140-
<!-- This option is needed to suppress warnings from sun.misc.Unsafe usage -->
141-
<javacArg>-XDignore.symbol.file</javacArg>
142-
</javacArgs>
143-
</configuration>
144138
</plugin>
145139
</plugins>
146140
</build>

common/variant/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,6 @@
6969
<plugin>
7070
<groupId>net.alchim31.maven</groupId>
7171
<artifactId>scala-maven-plugin</artifactId>
72-
<configuration>
73-
<javacArgs combine.children="append">
74-
<!-- This option is needed to suppress warnings from sun.misc.Unsafe usage -->
75-
<javacArg>-XDignore.symbol.file</javacArg>
76-
</javacArgs>
77-
</configuration>
7872
</plugin>
7973
</plugins>
8074
</build>

project/SparkBuild.scala

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1075,10 +1075,7 @@ object SparkProtobuf {
10751075
}
10761076

10771077
object Unsafe {
1078-
lazy val settings = Seq(
1079-
// This option is needed to suppress warnings from sun.misc.Unsafe usage
1080-
(Compile / javacOptions) += "-XDignore.symbol.file"
1081-
)
1078+
lazy val settings = Seq()
10821079
}
10831080

10841081

0 commit comments

Comments
 (0)