[Feature] provides sample option in python agent

[tsonglew]

Search before asking

• I had searched in the issues and found no similar feature requirement.

Description

Support sample option like SW_AGENT_SAMPLE in java agent

Use case

Reduce the trace storage load

Related issues

#5997

Are you willing to submit a pull request to implement this on your own?

• Yes I am willing to submit a pull request on my own!

Code of Conduct

• I agree to follow this project's Code of Conduct

[wu-sheng]

fyi @Superskyyy

[CodePrometheus]

Could you briefly describe your idea? Is it possible to dynamically update the value of sample based on the configuration file?

[tsonglew]

@CodePrometheus I will achieve the function through following tasks:

1. Add SW_AGENT_SAMPLE in skywalking/config.py
2. Create a sampling_service with try_sampling, reset_sampling_factor and other methods. try_sampling will add one to a counter property of sampling_service. reset_sampling_factor will clear the counter.
3. Modify skywalking/trace/context.py to check if sampling_service.try_sampling returns true every time before creating a new SpanContext. If sampling_service.try_sampling returns false, get_context should return NoopContext.
4. A scheduler thread will be started when initializing a sampling service, it will reset the sampling factor every 3 seconds.

Dynamically updating the value based on the configuration file or environment variables will not be implemented.

[wu-sheng]

Could you briefly describe your idea? Is it possible to dynamically update the value of sample based on the configuration file?

@CodePrometheus Could you be more specific about this? What do you mean based on file?

The above logic seems to be as same as Java agent sampling.

[CodePrometheus]

@CodePrometheus Could you be more specific about this? What do you mean based on file?

The above logic seems to be as same as Java agent sampling.

Yes, the above logic is similar to the existing sample_n_per_3_secs in Java agent. I want to refer to dynamic configuration, ref #6114

[wu-sheng]

I am not sure whether python agent supports dynamic configuration in the kernel already? @Superskyyy

[CodePrometheus]

I am not sure whether python agent supports dynamic configuration in the kernel already? @Superskyyy

Currently, this capability is not implemented in python-agent.

[wu-sheng]

@tsonglew Are you going to add this too?

[tsonglew]

@tsonglew Are you going to add this too?

Yes, I will create another mr for config change events

[wu-sheng]

Is there any update about this feature?

[tsonglew]

I'm still working on it. I will make it done within three weeks.