-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
super-high cost when searching for documents #1097
super-high cost when searching for documents #1097
Comments
After some digging, I just found the issue caused by a very large search_index.json, it will load when the user clicks the search input box. This javascript file comes from the upstream repo: https://github.com/squidfunk/mkdocs-material, in the latest documentation website of them, it will pre-loaded search index, and the index file size is only 200kb. Then I checked the content of pekko search index file, which is very large json array. Finally, I decided to look up the answer in the upstream repo, and I found this: squidfunk/mkdocs-material#904 |
It is Paradox that builds this json file. I'm not sure what we can do in the short term. Maybe, we should look at trying to offload the search to Google instead of using our own search with its own JSON file. See https://poi.apache.org/ - another Apache project site - its search is Google based. |
An example Google search
https://www.google.com/search?q=actor+site%3Apekko.apache.org |
IIRC, it was using the algolia for indexing and searching |
I don't think so, only akka uses algolia, we use paradox-material-theme which depends on mkdocs-material
I am using Docusaurus at work, they use the same way to implement offline search but won't stuck UI thread. |
I will try to handle this issue via an update paradox-material-theme. |
Note that sbt-paradox-material-theme was just transferred to the sbt org/community and we are currently in the process of making the necessary changes so it may take a bit of time before we can get to deploying the change |
I tried to upgrade to the latest mkdocs-material and found that the way it was built changed after the 5.x version, and only up-to 5.x version can avoid search blocking the main thread, and it seems that the implementation is through the need to precompile a search index file. I think this upgrade is no less difficult than rewriting upstream https://github.com/sbt/sbt-paradox-material-theme. We should consider replacing the search implementation to solve this ISSUE. |
Author of Material for MkDocs here. v5.x is from 2020, so pretty old. We made significant improvements on search in 9.x, which should be twice as fast and significantly cut down on index size, and will be replacing it with an entirely new implementation that will be much faster and more powerful in the near future. Related: |
@Roiocam sbt-paradox-theme has been ported over to the sbt org/package and 0.7.0 has just been published so you are now free to make changes against sbt-paradox-theme. |
Reproduce
Just search from https://pekko.apache.org/docs/pekko/current//index.html
Happened on:
I think this maybe a issue from paradox.
Self-diagnosis
Just a quick investigation from myself, the profiler shows that most of the time costs from a
reduce
function.I am not a frontend developer, can not deep dive to it.
Performance Profile
This is my profiler result.
Trace-20240204T004355.json
The text was updated successfully, but these errors were encountered: