From 66e32ac577d8ddddeca7d1288557ffa841081cb3 Mon Sep 17 00:00:00 2001 From: Aaron Niskode-Dossett Date: Wed, 24 Sep 2025 10:06:52 -0400 Subject: [PATCH 1/2] MINOR: parquet-avro tests should not debug to stderr --- .../apache/parquet/avro/TestAvroSchemaConverter.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java b/parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java index 130192e155..0ed3e4bef2 100644 --- a/parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java +++ b/parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java @@ -372,7 +372,7 @@ public void testArrayOfOptionalRecords() throws Exception { Schema schema = Schema.createRecord("HasArray", null, null, false); schema.setFields( Lists.newArrayList(new Schema.Field("myarray", Schema.createArray(optional(innerRecord)), null, null))); - System.err.println("Avro schema: " + schema.toString(true)); + System.out.println("Avro schema: " + schema.toString(true)); testRoundTripConversion( NEW_BEHAVIOR, @@ -398,7 +398,7 @@ public void testArrayOfOptionalRecordsOldBehavior() throws Exception { Schema schema = Schema.createRecord("HasArray", null, null, false); schema.setFields( Lists.newArrayList(new Schema.Field("myarray", Schema.createArray(optional(innerRecord)), null, null))); - System.err.println("Avro schema: " + schema.toString(true)); + System.out.println("Avro schema: " + schema.toString(true)); // Cannot use round-trip assertion because InnerRecord optional is removed testAvroToParquetConversion( @@ -418,7 +418,7 @@ public void testOldAvroListOfLists() throws Exception { Schema schema = Schema.createRecord("AvroCompatListInList", null, null, false); schema.setFields( Lists.newArrayList(new Schema.Field("listOfLists", listOfLists, null, JsonProperties.NULL_VALUE))); - System.err.println("Avro schema: " + schema.toString(true)); + System.out.println("Avro schema: " + schema.toString(true)); testRoundTripConversion( schema, @@ -462,7 +462,7 @@ public void testOldThriftListOfLists() throws Exception { Schema schema = Schema.createRecord("ThriftCompatListInList", null, null, false); schema.setFields( Lists.newArrayList(new Schema.Field("listOfLists", listOfLists, null, JsonProperties.NULL_VALUE))); - System.err.println("Avro schema: " + schema.toString(true)); + System.out.println("Avro schema: " + schema.toString(true)); // Cannot use round-trip assertion because repeated group names differ testParquetToAvroConversion( @@ -494,7 +494,7 @@ public void testUnknownTwoLevelListOfLists() throws Exception { Schema schema = Schema.createRecord("UnknownTwoLevelListInList", null, null, false); schema.setFields( Lists.newArrayList(new Schema.Field("listOfLists", listOfLists, null, JsonProperties.NULL_VALUE))); - System.err.println("Avro schema: " + schema.toString(true)); + System.out.println("Avro schema: " + schema.toString(true)); // Cannot use round-trip assertion because repeated group names differ testParquetToAvroConversion( From f1cb0346e7800538318bbd90e9664c87b3e72ea3 Mon Sep 17 00:00:00 2001 From: Aaron Niskode-Dossett Date: Wed, 24 Sep 2025 10:14:03 -0400 Subject: [PATCH 2/2] just remove them --- .../org/apache/parquet/avro/TestAvroSchemaConverter.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java b/parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java index 0ed3e4bef2..346fafe7d3 100644 --- a/parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java +++ b/parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java @@ -372,7 +372,6 @@ public void testArrayOfOptionalRecords() throws Exception { Schema schema = Schema.createRecord("HasArray", null, null, false); schema.setFields( Lists.newArrayList(new Schema.Field("myarray", Schema.createArray(optional(innerRecord)), null, null))); - System.out.println("Avro schema: " + schema.toString(true)); testRoundTripConversion( NEW_BEHAVIOR, @@ -398,7 +397,6 @@ public void testArrayOfOptionalRecordsOldBehavior() throws Exception { Schema schema = Schema.createRecord("HasArray", null, null, false); schema.setFields( Lists.newArrayList(new Schema.Field("myarray", Schema.createArray(optional(innerRecord)), null, null))); - System.out.println("Avro schema: " + schema.toString(true)); // Cannot use round-trip assertion because InnerRecord optional is removed testAvroToParquetConversion( @@ -418,7 +416,6 @@ public void testOldAvroListOfLists() throws Exception { Schema schema = Schema.createRecord("AvroCompatListInList", null, null, false); schema.setFields( Lists.newArrayList(new Schema.Field("listOfLists", listOfLists, null, JsonProperties.NULL_VALUE))); - System.out.println("Avro schema: " + schema.toString(true)); testRoundTripConversion( schema, @@ -462,7 +459,6 @@ public void testOldThriftListOfLists() throws Exception { Schema schema = Schema.createRecord("ThriftCompatListInList", null, null, false); schema.setFields( Lists.newArrayList(new Schema.Field("listOfLists", listOfLists, null, JsonProperties.NULL_VALUE))); - System.out.println("Avro schema: " + schema.toString(true)); // Cannot use round-trip assertion because repeated group names differ testParquetToAvroConversion( @@ -494,7 +490,6 @@ public void testUnknownTwoLevelListOfLists() throws Exception { Schema schema = Schema.createRecord("UnknownTwoLevelListInList", null, null, false); schema.setFields( Lists.newArrayList(new Schema.Field("listOfLists", listOfLists, null, JsonProperties.NULL_VALUE))); - System.out.println("Avro schema: " + schema.toString(true)); // Cannot use round-trip assertion because repeated group names differ testParquetToAvroConversion(