lint

Author: ArnavBalyan

parquet-column/src/main/java/org/apache/parquet/io/ValidatingRecordConsumer.java

@@ -48,6 +48,9 @@
 public class ValidatingRecordConsumer extends RecordConsumer {
   private static final Logger LOG = LoggerFactory.getLogger(ValidatingRecordConsumer.class);
 
+  private static final int UINT_8_MAX_VALUE = 255;
+  private static final int UINT_16_MAX_VALUE = 65535;
+
   private final RecordConsumer delegate;
 
   private Deque<Type> types = new ArrayDeque<>();
@@ -265,16 +268,16 @@ public Optional<Void> visit(LogicalTypeAnnotation.IntLogicalTypeAnnotation intTy
             if (!intType.isSigned()) {
               switch (intType.getBitWidth()) {
                 case 8:
-                  if (value < 0 || value > 255) {
+                  if (value < 0 || value > UINT_8_MAX_VALUE) {
                     throw new InvalidRecordException("Value " + value
-                        + " is out of range for UINT_8 (0-255) in field "
+                        + " is out of range for UINT_8 (0-" + UINT_8_MAX_VALUE + ") in field "
                         + currentType.getName());
                   }
                   break;
                 case 16:
-                  if (value < 0 || value > 65535) {
+                  if (value < 0 || value > UINT_16_MAX_VALUE) {
                     throw new InvalidRecordException("Value " + value
-                        + " is out of range for UINT_16 (0-65535) in field "
+                        + " is out of range for UINT_16 (0-" + UINT_16_MAX_VALUE + ") in field "
                         + currentType.getName());
                   }
                   break;

parquet-hadoop/src/test/java/org/apache/parquet/hadoop/example/TestStrictUnsignedIntegerValidation.java

@@ -19,11 +19,10 @@
 package org.apache.parquet.hadoop.example;
 
 import static org.apache.parquet.schema.LogicalTypeAnnotation.intType;
+import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.BINARY;
 import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.INT32;
 import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.INT64;
-import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.BINARY;
 import static org.junit.Assert.assertThrows;
-import org.apache.parquet.io.api.Binary;
 
 import java.io.File;
 import java.io.IOException;
@@ -32,6 +31,7 @@
 import org.apache.parquet.example.data.simple.SimpleGroupFactory;
 import org.apache.parquet.hadoop.ParquetWriter;
 import org.apache.parquet.io.InvalidRecordException;
+import org.apache.parquet.io.api.Binary;
 import org.apache.parquet.schema.MessageType;
 import org.apache.parquet.schema.Types;
 import org.junit.Rule;
@@ -277,10 +277,8 @@ public void testValidationCanBeExplicitlyDisabled() throws IOException {
 
   @Test
   public void testBasicValidation() throws IOException {
-    MessageType schema = Types.buildMessage()
-        .required(INT32)
-        .named("int32_field")
-        .named("test_schema");
+    MessageType schema =
+        Types.buildMessage().required(INT32).named("int32_field").named("test_schema");
 
     File tempFile = new File(tempFolder.getRoot(), "basic_validation.parquet");
     Path outputPath = new Path(tempFile.getAbsolutePath());
@@ -295,10 +293,8 @@ public void testBasicValidation() throws IOException {
       Group validGroup = groupFactory.newGroup().append("int32_field", 42);
       writer.write(validGroup);
 
-      MessageType stringSchema = Types.buildMessage()
-          .required(BINARY)
-          .named("int32_field")
-          .named("test_schema");
+      MessageType stringSchema =
+          Types.buildMessage().required(BINARY).named("int32_field").named("test_schema");
 
       SimpleGroupFactory stringGroupFactory = new SimpleGroupFactory(stringSchema);
       Group invalidGroup = stringGroupFactory.newGroup().append("int32_field", Binary.fromString("not_an_int"));