Repository navigation
Conversation
Apache Yetus test-patch report
This message was automatically generated. |
|
sebastian-nagel
approved these changes
Oct 10, 2026
sebastian-nagel
left a comment
sebastian-nagel
left a comment
Contributor
There was a problem hiding this comment.
Thanks, @lewismc!
Looks good. There are a few passages which would need that the formatting is applied. It's on you whether to fix this now. We can also address it later.
| ArrayList<String> segmentList = new ArrayList<>(); | ||
| if(segments instanceof ArrayList) { | ||
| segmentList = (ArrayList<String>)segments; | ||
| segmentList = (ArrayList<String>)segments; |
Contributor
There was a problem hiding this comment.
Looks like here the code formatting should be applied. The indentation is now lost.
But also the preceding line if(segments ... does follow the code formatting rules.
|
|
||
| public NutchPublishers(Configuration conf) { | ||
| this.conf = conf; | ||
| this.conf = conf; |
Contributor
There was a problem hiding this comment.
Same as above: indentation lost.
| * An example output run showing the number of encountered status | ||
| * codes such as 200, 300, and a count of un-fetched record. | ||
| * | ||
| * 38 200 |
Contributor
There was a problem hiding this comment.
Should be inside <pre>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the remainder of NUTCH-3215. The first pull request only removed trailing spaces. Yetus treats "end in blanks" as any trailing space or tab, and it has a second, separate vote for tab characters anywhere in a line. Both of those were still present after #971 merged.
Whilst I was looking at this, I was curious about whether the Eclipse profile in
eclipse-codeformat.xmland Yetus agreed/disagreed on anything.The Eclipse profile setstabulation.charto space, with bothtabulation.sizeandindentation.sizeat2. Yetus blanks fails a file that contains a tab character, or a line that ends in a space or a tab. A Java file formatted with that profile satisfies both of those checks. Yetus does not care that the indent is 2 rather than 4, and it does not apply the Eclipse line length of 80.Two limits keep them from being the same convention:
After running Yetus locally everything checks out