There is now multiple build WARNING output on every use of `exportAntProperties` as of 3.2.0

[jbindel]

Affected version

3.2.0

Bug description

There is now WARNING output on every use of exportAntProperties

Because all maven properties are imported to ant tasks, all properties will get a WARNING output in the build that uses the AntRun plugin and exports properties from the Ant task.

The cause of this is a change to the logging level from the original, expected DEBUG level to its current WARNING level.

maven-antrun-plugin/src/main/java/org/apache/maven/plugins/antrun/AntRunMojo.java

Line 465 in 629e579

getLog().warn("Ant property '" + key + "=" + mavenProperties.getProperty(key)

Expected: Using the exportAntProperties with value of true should not generate WARNING output in a Maven build.
Actual: The build outputs a warning for every existing Maven property that is set.

It may be acceptable and useful to output a warning if the value of the Ant property and the value of an existing Maven property do not match as that would indicate something odd.

[cortlepp]

I have the same issue/annoyance, it would be really nice if we could get this resolved. Especially since @jbindel already went through the trouble and implemented a fix in #349 . The CI of that PR is failing currently, but from the log messages this looks like a temporary network problem, so it should be fixed by merely restarting the checks.

[haxorof]

Just for connecting the issues which caused the mentioned change: #108 (#201).

So now when you have many properties it will be a lot of warnings by default which is not nice at all to have in your Maven output. With the current implemention it would have been workable if some plugin configuration was added to get back to the old behavior or skip that logging completely since it was only visible on debug before.

[cortlepp]

(Friendly ping @elharo 🙂)

[clafren1]

In the open PR, it may not be necessary to do a value comparison between the ANT property and the corresponding Maven property, if it exists.

Based on a simple test, it doesn't seem possible to override a Maven property from the antrun plugin, even with the <local> task.

This sample POM demonstrates the immutable behavior:

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
  <modelVersion>4.0.0</modelVersion>
  <groupId>my.groupId</groupId>
  <artifactId>my-artifactId</artifactId>
  <version>1.0</version>
  <packaging>pom</packaging>
  <properties>
    <some.property>maven</some.property>
  </properties>
  <build>
    <plugins>
      <plugin>
        <artifactId>maven-antrun-plugin</artifactId>
        <version>3.2.0</version>
        <executions>
          <execution>
            <id>print-property</id>
            <phase>verify</phase>
            <goals>
              <goal>run</goal>
            </goals>
            <configuration>
              <target>
                <echo level="info">some.property (maven): ${some.property}</echo>
                <property name="some.property" value="ant"/>
                <echo level="info">some.property (ant): ${some.property}</echo>
                <local name="some.property"/>
                <property name="some.property" value="local"/>
                <echo level="info">some.property (local): ${some.property}</echo>
              </target>
            </configuration>
          </execution>
        </executions>
      </plugin>
    </plugins>
  </build>
</project>

The console output from running mvn clean verify with Maven 3.9.11 is:

[INFO]      [echo] some.property (maven): maven
[INFO]      [echo] some.property (ant): maven
[INFO]      [echo] some.property (local): maven

some.property is defined as a POM property and its value remains constant despite the <property> & <local> ANT tasks.

Alternative ways to remove the unwanted warnings could be:

• revert the log message back to debug, as the log level change had no obvious link to the limitation that needed to be documented in the original issue
• completely ignore ANT properties that are also Maven properties during the export step, as their values can not be changed with this plugin