What happened
The required CI / test check on main fails at Test CI planner after #4462 merged on top of #4461.
#4461 moved planning into the required test job, so later steps must read steps.plan.outputs.*. The localized TUI copy step added by #4462 still reads needs.plan.outputs.code, which the workflow policy test rejects and which prevents the remaining validation steps from running.
Once that reference is corrected, the TUI copy boundary gate also exposes the other side of the concurrent merge:
Expected: the required check passes, code changes run the localized-copy gate, every TUI source file is classified, and /copy usage follows the active locale.
How to reproduce
-
Check out 777b2cef84d4d361e3664a7c3519bd8b6ed948fd.
-
Run:
node --test --test-concurrency=1 \
scripts/ci-test-plan.test.mjs \
scripts/ci-workflow-policy.test.mjs \
scripts/verify-windows-harness.test.mjs
-
Observe planning runs first and every later step gates on its outputs fail because .github/workflows/ci.yml contains needs.plan.outputs.
-
Change that condition to steps.plan.outputs.code, install dependencies, and run npm run check:tui-copy.
-
Observe the unclassified /copy TUI source files; after classifying the user-facing command module, the hard-coded usage notice also falls under the localized-copy boundary.
Environment
- Maka commit:
777b2cef84d4d361e3664a7c3519bd8b6ed948fd
- OS: GitHub-hosted Ubuntu 24.04
- Surface: GitHub Actions CI and TUI/CLI
- Node.js: 24 (workflow toolchain)
Logs, screenshots, or additional context
Failing run: https://github.com/apache/maka/actions/runs/33545595685
The failure is a merge-integration issue: both contributing changes passed independently, but their combined result on main violates the new workflow and TUI-copy contracts.
Submitted by @liuxiaocs7 with substantive implementation and drafting assistance from Codex.
What happened
The required
CI / testcheck onmainfails atTest CI plannerafter #4462 merged on top of #4461.#4461 moved planning into the required
testjob, so later steps must readsteps.plan.outputs.*. The localized TUI copy step added by #4462 still readsneeds.plan.outputs.code, which the workflow policy test rejects and which prevents the remaining validation steps from running.Once that reference is corrected, the TUI copy boundary gate also exposes the other side of the concurrent merge:
tui-copy-command.tsandtui-clipboard.ts, added by feat(tui): add /copy to copy the last reply or transcript to the clipboard #4359, are not classified by the new all-TUI-file gate./copyinvalid-argument notice is still a hard-coded EnglishUsage: /copy [all]string instead of using the typed locale catalog.Expected: the required check passes, code changes run the localized-copy gate, every TUI source file is classified, and
/copyusage follows the active locale.How to reproduce
Check out
777b2cef84d4d361e3664a7c3519bd8b6ed948fd.Run:
Observe
planning runs first and every later step gates on its outputsfail because.github/workflows/ci.ymlcontainsneeds.plan.outputs.Change that condition to
steps.plan.outputs.code, install dependencies, and runnpm run check:tui-copy.Observe the unclassified
/copyTUI source files; after classifying the user-facing command module, the hard-coded usage notice also falls under the localized-copy boundary.Environment
777b2cef84d4d361e3664a7c3519bd8b6ed948fdLogs, screenshots, or additional context
Failing run: https://github.com/apache/maka/actions/runs/33545595685
The failure is a merge-integration issue: both contributing changes passed independently, but their combined result on
mainviolates the new workflow and TUI-copy contracts.Submitted by @liuxiaocs7 with substantive implementation and drafting assistance from Codex.