You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current main at 689a4515f15870d3c0ae9ee66c2f2021b34c0e2b has two entries for session metadata migration version 30 in packages/storage/src/sqlite-session-metadata-schema.ts:
MIGRATIONS is constructed as a JavaScript Map, so the later [30, ...] silently replaces the earlier one. A fresh database advances session_metadata_schema to version 30 after creating only the coordination index. The message-admission store then fails with no such table: message_admissions.
Reproduction
On current main after building @maka/core and @maka/storage:
The complete session metadata file reports five failures in the admission/handoff/reorder tests. I reproduced the same failure after stashing an unrelated Windows-baseline branch and rebuilding pure upstream/main, so it is not introduced by that branch.
Merge interaction
Both PR heads could be green independently because each owned version 30 on its own base. The conflict is semantic rather than textual and appeared only after both merges.
Required compatibility
Simply renumbering the latest source entry is insufficient because version-30 databases may already exist in three shapes:
current main: same as (2), with schema version recorded as 30.
Recommend bumping the current schema to 31 and making migration 31 converge every version-30 shape with guarded creation of both authorities. Add tests for all three starting shapes and a contract that prevents duplicate migration-version declarations from being silently collapsed by Map construction.
This is a current-main storage migration blocker, independent of #2624.
Problem
Current
mainat689a4515f15870d3c0ae9ee66c2f2021b34c0e2bhas two entries for session metadata migration version30inpackages/storage/src/sqlite-session-metadata-schema.ts:24a97c54e: createsmessage_admissionsandcancelled_message_admissions;f9d960d8c: createssession_metadata_one_workhub_coordination_session.MIGRATIONSis constructed as a JavaScriptMap, so the later[30, ...]silently replaces the earlier one. A fresh database advancessession_metadata_schemato version 30 after creating only the coordination index. The message-admission store then fails withno such table: message_admissions.Reproduction
On current main after building
@maka/coreand@maka/storage:Result:
The complete session metadata file reports five failures in the admission/handoff/reorder tests. I reproduced the same failure after stashing an unrelated Windows-baseline branch and rebuilding pure
upstream/main, so it is not introduced by that branch.Merge interaction
Both PR heads could be green independently because each owned version 30 on its own base. The conflict is semantic rather than textual and appeared only after both merges.
Required compatibility
Simply renumbering the latest source entry is insufficient because version-30 databases may already exist in three shapes:
Recommend bumping the current schema to 31 and making migration 31 converge every version-30 shape with guarded creation of both authorities. Add tests for all three starting shapes and a contract that prevents duplicate migration-version declarations from being silently collapsed by
Mapconstruction.This is a current-main storage migration blocker, independent of #2624.